Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 175502 (perl-Gtk2-Spell) - Review Request: perl-Gtk2-Spell
Summary: Review Request: perl-Gtk2-Spell
Keywords:
Status: CLOSED NEXTRELEASE
Alias: perl-Gtk2-Spell
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Chris Weyl
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-12-12 00:17 UTC by Chris Weyl
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-04-25 22:08:49 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Chris Weyl 2005-12-12 00:17:15 UTC 
Spec Name or Url: http://www.mindspring.com/~cweyl/perl-Gtk2-Spell/perl-Gtk2-Spell.spec
SRPM Name or Url: http://www.mindspring.com/~cweyl/perl-Gtk2-Spell/perl-Gtk2-Spell-1.03-1.ckw.fc4.src.rpm

Description: gtkspell bindings for perl(Gtk2)
Perl bindings to GtkSpell, used in concert with Gtk2::TextView. Provides mis-spelled word highlighting in red and offers a right click pop-up menu with suggested corrections.

Please ignore the ".ckw.fc4" in the srpm's filename -- I have %dist set to that in my ~/.rpmmacros.

This is my first extras package, and I'm seeking a sponsor! :)
Comment 1 Kevin Fenzi 2005-12-14 01:00:29 UTC 
NOTE: I cannot sponsor, but here's a review. :)

Good: 
- Package name is good. 
- License is good and matches upstream (LGPL)
- Source is good and matches upstream
- builds fine on fc4/devel. 
- package seems to work as expected using the include test perl script. 

Minor:
- rpmlint warning: 
W: perl-Gtk2-Spell devel-file-in-non-devel-package
/usr/lib/perl5/vendor_perl/5.8.7/i386-linux-thread-multi/Gtk2/Spell/Install/gtk2spellperl.h
- why bother to use the %realname macro? Is the package name expected to change
very often? :) 
- why the 'echo n | ' in the build section? 
- Might include the Changelog file as a doc.
Comment 2 Chris Weyl 2005-12-14 18:26:47 UTC 
Updated spec/srpm:
Spec Name or Url:
http://www.mindspring.com/~cweyl/perl-Gtk2-Spell/perl-Gtk2-Spell.spec
SRPM Name or Url:
http://www.mindspring.com/~cweyl/perl-Gtk2-Spell/perl-Gtk2-Spell-1.03-2.ckw.fc4.src.rpm

%realname is used as I was creating a bunch of module rpms for my own use; this
macro allowed me to quickly take a template spec file and cusomize it.

Minor issues addressed:
- 'echo n |' in %build nixed.
- ChangeLog included as a doc
Comment 3 Josh Boyer 2006-01-27 19:30:25 UTC 
Good:

All of the above and no more rpmlint warnings

TODOs:

- perl is not needed as a BuildRequires
- ditch the %realname macro

Fixup those two remaining issues and I think this is ready for approval
Comment 4 Chris Weyl 2006-02-17 01:40:03 UTC 
Updated spec/srpm:
Spec Name or Url:
http://www.mindspring.com/~cweyl/perl-Gtk2-Spell/perl-Gtk2-Spell.spec
SRPM Name or Url:
http://www.mindspring.com/~cweyl/perl-Gtk2-Spell/perl-Gtk2-Spell-1.03-1.ckw.fc4.src.rpm

TODOs from #3 addressed; release tag reset to 1.
Comment 5 Ralf Corsepius 2006-02-17 10:50:17 UTC 
Please remove the perl_* stuff at the very beginning of the spec.

Also, please don't reset the release tag, and increment it instead even during
reviews.
Comment 6 Chris Weyl 2006-02-18 16:27:45 UTC 
Updated spec/srpm:
Spec Name or Url:
http://www.mindspring.com/~cweyl/perl-Gtk2-Spell/perl-Gtk2-Spell.spec
SRPM Name or Url:
http://www.mindspring.com/~cweyl/perl-Gtk2-Spell/perl-Gtk2-Spell-1.03-4.ckw.fc4.src.rpm

Updated per #5.
Comment 7 Josh Boyer 2006-02-20 13:02:23 UTC 
This package is accepted.

Chris, you'll need to apply for CVS access here:

https://admin.fedora.redhat.com/accounts/

In the meantime, I've imported the SRPM into CVS.  Once you get CVS access, you
can request a build and create any branches you'd like.
Comment 8 Christian Iseli 2006-03-28 15:25:02 UTC 
Any particular reason why this package is not yet built and in owners.list ?
Comment 9 Chris Weyl 2006-03-28 15:46:03 UTC 
Yes, Real World/Life issues.  I'm just at the tail end of a transition from
living/working in Connecticut to California; I should be back up & running by
the end of the week.  Assuming the movers show up with my stuff today, of course :)
Comment 10 Hans de Goede 2006-06-08 07:40:24 UTC 
Remving form FE_NEEDSPONSOR tracker bug, since this is closed.
Note You need to log in before you can comment on or make changes to this bug.