Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1768246 - Bad text foreground color after webkit2gtk3 upgrade
Summary: Bad text foreground color after webkit2gtk3 upgrade
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: evolution
Version: 30
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Milan Crha
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-11-03 17:00 UTC by pkoz
Modified: 2019-11-27 21:38 UTC (History)
10 users (show)

Fixed In Version: evolution-3-34.1 evolution-3.32.5-1.fc30
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-11-04 16:59:23 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
Example e-mail with text unreadable with 2.26 and readable with 2.24 webkit2gtk3. (4.80 KB, application/mbox)
2019-11-03 17:00 UTC, pkoz 		no flags Details
View All

Description pkoz 2019-11-03 17:00:19 UTC 
Created attachment 1632246 [details]
Example e-mail with text unreadable with 2.26 and readable with 2.24 webkit2gtk3.

Description of problem:
With 2.26, certain HTML mails are unreadable in evolution: letters are white foreground on white background.


Version-Release number of selected component (if applicable):
webkit2gtk3-2.26.1-3.fc30.x86_64
webkit2gtk3-jsc-2.26.1-3.fc30.x86_64

evolution-3.32.4-1.fc30.x86_64

How reproducible:
Downgrading to 2.24 solves the problem, mails read all right.
Upgrading to 2.26 brings back the problem again.


Steps to Reproduce:
1.
2.
3.

Actual results:
webkit2gtk3-2.26.1-3.fc30.x86_64
webkit2gtk3-jsc-2.26.1-3.fc30.x86_64
evolution-3.32.4-1.fc30.x86_64
do not not show mail text

Expected results:
webkit2gtk3-2.24.1-1.fc30.x86_64
webkit2gtk3-jsc-2.24.1-1.fc30.x86_64
evolution-3.32.4-1.fc30.x86_64
do show mail text

Additional info:
Attached is an example e-mail.
Comment 1 Tomas Popela 2019-11-04 05:41:15 UTC 
Changing to Evolution as I think that this was already fixed there, but Milan knows more about this matter.
Comment 2 Milan Crha 2019-11-04 16:59:23 UTC 
Right, WebKitGTK+ 2.26.x is full or various regressions from 2.24.x. This particular one has its workaround in upstream Evolution at [1]. That's for 3.34.1+ of Evolution.

I didn't plan to backport that change into Fedora 30, also because other WebKitGTK+ 2.26 regressions, those bigger, like [2].

Michael (Catanzaro), I thought you are not going to update webkit2gtk3 with knowingly broken ABI/functionality in older Fedora than 31. It seems I misunderstood our conversation in WebKit/upstream.

I suggest to Fedora 30 users to downgrade webkit2gtk3 to 2.24.x version. Not only Evolution is affected by the 2.26.x changes.

[1] https://gitlab.gnome.org/GNOME/evolution/issues/617
[2] https://gitlab.gnome.org/GNOME/evolution/issues/587
Comment 3 Michael Catanzaro 2019-11-04 20:11:07 UTC 
So 2.24.x is affected by several known CVEs that will not be fixed in 2.24. I don't think going backwards would be advisable. We waited much longer than usual to upgrade to 2.26 due to all the trouble with regressions, and decided not to upgrade F29 at all.

I didn't know about [1], sorry.

For [2], Carlos Garcia manually investigated everything in Debian and decided only Geary and Evolution would require workarounds. We have a hack patch to use single-process model when prgname matches "geary" or "evolution". I'm not aware of reports of trouble in other apps.
Comment 4 Milan Crha 2019-11-05 08:55:20 UTC 
Oh, I see, there's a misinformation between us (WebKitGTK+ and Evolution projects) and with that related misunderstanding(s).

I understand why you want to get the latest CVE-s to the users, it makes perfect sense. I'm not sure whether they are related to the way Evolution uses WebKit, but, of course, Evolution is not the only user of WebKit. (I do not know if it makes sense what I want to say.)

I'm pretty sure I noticed an issue in other application than evo and geary, but I cannot find the reference to it at the moment (not due to [3]).

I kind of hesitate to do an Evolution 3.32.x upstream release with fixes for WebKitGTK+ 2.26.x (would that be against Debian policy?), thus maybe do this only for Fedora (if I manage to find all the related upstream bugs [3]), but that won't help to other distributions. Not talking that some distributions do not update even the .2 and/or later upstream releases...

I mean, I'm unsure how to deal with this in the best way, to cover the most of the users and distributions. Any suggestions?

[3] https://gitlab.com/gitlab-org/gitlab/issues/35611
Comment 5 Michael Catanzaro 2019-11-05 14:09:56 UTC 
I think you should absolutely do another 3.32 release because all distributions providing security updates for WebKit will need to update it soon.
Comment 6 Michael Catanzaro 2019-11-05 14:10:54 UTC 
(Of course, if the change is a bug in WebKit, ideally that would be fixed as well.)
Comment 7 Milan Crha 2019-11-06 07:48:30 UTC 
(In reply to Michael Catanzaro from comment #6)
> (Of course, if the change is a bug in WebKit, ideally that would be fixed as
> well.)

That's the thing. I do not know whether it's a bug or not, it's just changed behavior on the WebKitGTK+ side.

From the [4]:

> I can confirm this with WebKitGTK+ 2.26.0. Looking in its inspector
> I see the iframe has set background-color and color styles, but
> these do not propagate into the inner content, though the main
> difference with the new WebKitGTK+ might be that they define
> color:text for <html>, which wasn't the case in the past. These
> do not seem to be possible to override on the iframe element,
> at least according to what I see in the webkit's inspector.

The upstream fix/workaround was to set the color style to "inherit".

[4] https://gitlab.gnome.org/GNOME/evolution/issues/617#note_602193
Comment 8 Fedora Update System 2019-11-11 16:02:47 UTC 
FEDORA-2019-4213c52f7b has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-4213c52f7b
Comment 9 Milan Crha 2019-11-11 16:04:05 UTC 
The above update is with the 3.32.5 upstream release, to which I added the fix for this.
Comment 10 Fedora Update System 2019-11-12 03:08:01 UTC 
evolution-3.32.5-1.fc30, evolution-data-server-3.32.5-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-4213c52f7b
Comment 11 Michael Catanzaro 2019-11-12 16:03:43 UTC 
Does a WebKit bug report exist?

Seems like this will be a big problem for a lot of distros, especially since there are now two security advisories to upgrade to 2.26.
Comment 12 Milan Crha 2019-11-12 16:09:42 UTC 
No idea, I'm sorry. I only saw the new behaviour, which might or might not be intentional. As I do not know where to look for the change in the sources I didn't try to find the exact commit which changed the behaviour. I even did not try to find which version of webkit2gtk3 begun to "misbehave".
Comment 13 Fedora Update System 2019-11-26 23:51:09 UTC 
evolution-3.32.5-1.fc30, evolution-data-server-3.32.5-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
Comment 14 pkoz 2019-11-27 21:38:01 UTC 
Mails are now readable with evolution 3.32.5-1 and webkit2gtk3 2.26.2-1 in FC30.
Note You need to log in before you can comment on or make changes to this bug.