Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1785974 - Review Request: python-qtsass - Compile SCSS files to valid Qt stylesheets
Summary: Review Request: python-qtsass - Compile SCSS files to valid Qt stylesheets
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1770859
Blocks: 1785982
TreeView+ depends on / blocked
 
Reported: 2019-12-22 22:12 UTC by Mukundan Ragavan
Modified: 2020-03-16 23:36 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-03-16 23:36:47 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+

Attachments (Terms of Use)

Description Mukundan Ragavan 2019-12-22 22:12:57 UTC 
Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/qtsass/rnd1/python-qtsass.spec
SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/qtsass/rnd1/python-qtsass-0.1.1-1.fc31.src.rpm

Description:
SASS brings countless amazing features to CSS. Besides being used in web 
development, CSS is also the way to stylize Qt-based desktop applications. 
However, Qt's CSS has a few variations that prevent the direct use of 
SASS compiler. The purpose of this tool is to fill the gap between SASS 
and Qt-CSS by handling those variations.

Fedora Account System Username: nonamedotc

koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=39893134
Comment 1 Zbigniew Jędrzejewski-Szmek 2019-12-23 15:57:00 UTC 
%description is repeated, defining it once as a macro using %{expand:} would  be nice.

%{python3_sitelib}/%{pypi_name} — please add "/" at the end.

- nothing provides python3.8dist(pathtools) >= 0.1.1 needed by python3-watchdog-0.8.3-13.fc32.noarch
Comment 2 Zbigniew Jędrzejewski-Szmek 2019-12-23 16:02:44 UTC 
Oh, we have python3-watchdog, but it FTI:
  - nothing provides python3.8dist(pathtools) >= 0.1.1 needed by python3-watchdog-0.8.3-13.fc32.noarch

https://bugzilla.redhat.com/show_bug.cgi?id=1770859
Comment 3 Mukundan Ragavan 2020-01-12 16:03:43 UTC 
With all other reviews done, only this and qdarkstyle remain.

We are really waiting for watchdog/pathtools.
Comment 4 Mukundan Ragavan 2020-02-14 02:31:35 UTC 
Looks like we have pathtools in rawhide. @Zbigniew - Can we proceed with the review here?
Thanks!
Comment 5 Zbigniew Jędrzejewski-Szmek 2020-02-14 16:55:41 UTC 
I'm AFK until the end of next week. I can finish the review then. If somebody wants to take over before that, please do.
Comment 6 Mukundan Ragavan 2020-03-01 14:38:20 UTC 
@Zbigniew - have time for this? thanks.
Comment 7 Zbigniew Jędrzejewski-Szmek 2020-03-01 16:26:15 UTC 
I see 0.2.2 on github, but 0.1.1 is packaged. Please update to the latest version.
Comment 8 Mukundan Ragavan 2020-03-01 21:50:17 UTC 
0.2.2 is tagged as a pre-release version. Pypi also has 0.1.1

See - https://pypi.org/project/qtsass/#history

It does look like 0.3 is around the horizon though.

https://github.com/spyder-ide/qtsass/issues/45

I can upload 0.3 when released and ping again.
Comment 9 Zbigniew Jędrzejewski-Szmek 2020-03-01 22:30:45 UTC 
Yeah, maybe let's wait in that case. If it doesn't happen in a week, I'll just review the older version.
Comment 10 Mukundan Ragavan 2020-03-16 09:46:12 UTC 
Can we move forward with this? 0.3 is not released yet. I would like to get spyder updated to 4.x.

Thanks.
Comment 11 Zbigniew Jędrzejewski-Szmek 2020-03-16 17:12:53 UTC 
+ package name is OK
+ latest version
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ BR/R/Provides looks OK
+ builds and installs and works OK on basic examples
- %check is missing, it'd be nice to add it

Package is APPROVED.
Comment 12 Gwyn Ciesla 2020-03-16 23:00:38 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-qtsass
Comment 13 Mukundan Ragavan 2020-03-16 23:36:47 UTC 
Thanks for the review. Built on rawhide. I will add %check with the next change I make.
Note You need to log in before you can comment on or make changes to this bug.