Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1786653 (androguard) - Review Request: androguard - Reverse engineering, mal- or goodware analysis of Android applications
Summary: Review Request: androguard - Reverse engineering, mal- or goodware analysis o...
Keywords:
Status: CLOSED RAWHIDE
Alias: androguard
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1786632 python-nose-timer python-magic
Blocks: FE-SECLAB androwarn
TreeView+ depends on / blocked
 
Reported: 2019-12-26 19:59 UTC by Fabian Affolter
Modified: 2020-05-24 15:33 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-05-24 15:33:35 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+

Attachments (Terms of Use)

Description Fabian Affolter 2019-12-26 19:59:23 UTC 
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/androguard.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/androguard-3.3.5-1.fc31.src.rpm

Project URL: https://github.com/androguard/androguard/

Description:
Androguard is a tool to play with Android files.

- DEX, ODEX
- APK
- Android’s binary xml
- Android resources
- Disassemble DEX/ODEX bytecodes
- Decompiler for DEX/ODEX files

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=39938137

rpmlint output:
$ rpmlint androguard-3.3.5-1.fc31.src.rpm 
androguard.src: W: spelling-error Summary(en_US) mal -> lam, ma, ml
androguard.src: W: spelling-error Summary(en_US) goodware -> good ware, good-ware, goodhearted
androguard.src: W: spelling-error %description -l en_US xml -> XML, ml
androguard.src: W: spelling-error %description -l en_US bytecodes -> byte codes, byte-codes, postcodes
androguard.src:40: W: macro-in-comment %check
androguard.src:41: W: macro-in-comment %{__python3}
1 packages and 0 specfiles checked; 0 errors, 6 warnings.

$ rpmlint androguard-3.3.5-1.fc31.noarch.rpm 
androguard.noarch: W: spelling-error Summary(en_US) mal -> lam, ma, ml
androguard.noarch: W: spelling-error Summary(en_US) goodware -> good ware, good-ware, goodhearted
androguard.noarch: W: spelling-error %description -l en_US xml -> XML, ml
androguard.noarch: W: no-manual-page-for-binary androarsc.py
androguard.noarch: W: no-manual-page-for-binary androaxml.py
androguard.noarch: W: no-manual-page-for-binary androcg.py
androguard.noarch: W: no-manual-page-for-binary androdd.py
androguard.noarch: W: no-manual-page-for-binary androdis.py
androguard.noarch: W: no-manual-page-for-binary androguard
androguard.noarch: W: no-manual-page-for-binary androgui.py
androguard.noarch: W: no-manual-page-for-binary androlyze.py
androguard.noarch: W: no-manual-page-for-binary androsign.py
1 packages and 0 specfiles checked; 0 errors, 12 warnings.

Fedora Account System Username: fab
Comment 1 Robert-André Mauchin 🐧 2019-12-27 20:54:01 UTC 
 - Generate the doc with Sphinx


BuildRequires:  python3dist(sphinx)
BuildRequires:  python3dist(sphinx-rtd-theme)
BuildRequires:  python3dist(sphinxcontrib-programoutput) > 0.8
BuildRequires:  python3dist(asn1crypto)
BuildRequires:  python3dist(click)
BuildRequires:  python3dist(future)
BuildRequires:  python3dist(lxml)
BuildRequires:  python3dist(ipython)
BuildRequires:  python3dist(networkx)
BuildRequires:  python3dist(pydot)
BuildRequires:  python3dist(python-magic) (To be packaged)

[…]

%install
%py3_install

# generate html docs 
PATH=%{buildroot}%{_bindir}:$PATH PYTHONPATH=%{buildroot}%{python3_sitelib} sphinx-build-3 docs html
# remove the sphinx-build leftovers
rm -rf html/.{doctrees,buildinfo}

 - Include examples in %doc

%doc html examples

 - Probably using a doc noarch subpackage

%package docs
Summary:        Androguard documentation
%description docs
Documentation for Androguard

[…]

%files docs
%doc html examples

 - The python-magic provided by Fedora ("file-magic", https://pypi.org/project/file-magic/) is not the python-magic expected by Androguard: https://pypi.org/project/python-magic/0.4.15/
  Please package https://pypi.org/project/python-magic/0.4.15 (pyp2rpm -b3 python-magic) and add it to the BR and RR. Not sure what naming you should use? python-python-magic? 

 - The tests mostly run without nose-timer: there is one failure regarding magic above and another one. Investigate with upstream.
Comment 2 Fabian Affolter 2020-04-01 15:13:01 UTC 
(In reply to Robert-André Mauchin from comment #1)
>  - Generate the doc with Sphinx

Documentation in sub package
 
>  - The python-magic provided by Fedora ("file-magic",
> https://pypi.org/project/file-magic/) is not the python-magic expected by
> Androguard: https://pypi.org/project/python-magic/0.4.15/
>   Please package https://pypi.org/project/python-magic/0.4.15 (pyp2rpm -b3
> python-magic) and add it to the BR and RR. Not sure what naming you should
> use? python-python-magic? 

Should be resolved now. Original package was renamed and the new one is available

>  - The tests mostly run without nose-timer: there is one failure regarding
> magic above and another one. Investigate with upstream.

Tests enabled as dependency is present now.

%changelog
* Wed Apr 01 2020 Fabian Affolter <mail> - 3.3.5-2
- Add docs subpackage (rhbz#1786653)
- Enable tests
- Fix requirements

Updated files:
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/androguard.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/androguard-3.3.5-2.fc31.src.rpm
Comment 3 Robert-André Mauchin 🐧 2020-04-02 16:46:18 UTC 
LGTM, package approved.
Comment 4 Gwyn Ciesla 2020-04-02 18:45:46 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/androguard
Note You need to log in before you can comment on or make changes to this bug.