1792989 – python-geopy fails to build with Python 3.9: imports abc from collections

Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1792989 - python-geopy fails to build with Python 3.9: imports abc from collections

Summary: python-geopy fails to build with Python 3.9: imports abc from collections

Keywords:
Status:	CLOSED DEFERRED
Alias:	None
Product:	Fedora
Classification:	Fedora
Component:	python-geopy
Sub Component:
Version:	rawhide
Hardware:	Unspecified
OS:	Unspecified
Priority:	unspecified
Severity:	unspecified
Target Milestone:	---
Assignee:	Fabian Affolter
QA Contact:	Fedora Extras Quality Assurance
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:	PYTHON39
TreeView+	depends on / blocked

Reported:	2020-01-20 13:18 UTC by Miro Hrončok
Modified:	2020-02-28 09:08 UTC (History)
CC List:	6 users (show)
Fixed In Version:
Doc Type:	If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:	2020-02-28 09:08:57 UTC
Type:	Bug
Embargoed:
Dependent Products:

Attachments	(Terms of Use)

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Github	geopy geopy pull 390	0	None	open	Fix collections.abc import for Python 3.9	2020-03-04 12:15:47 UTC

Description Miro Hrončok 2020-01-20 13:18:39 UTC

python-geopy fails to build with Python 3.9.0a2.

________________ TestDefaultDistanceClass.test_lonlat_function _________________
test/test_distance.py:294: in test_lonlat_function
    self.assertEqual(point, (41.49008, -71.312796, 0))
geopy/point.py:264: in __eq__
    if not isinstance(other, collections.Iterable):
E   AttributeError: module 'collections' has no attribute 'Iterable'
______________________ LocationTestCase.test_location_eq _______________________
test/test_location.py:145: in test_location_eq
    self.assertEqual(loc1, loc2)
geopy/location.py:136: in __eq__
    self._point == other._point and
geopy/point.py:264: in __eq__
    if not isinstance(other, collections.Iterable):
E   AttributeError: module 'collections' has no attribute 'Iterable'
_____________________ LocationTestCase.test_location_init ______________________
test/test_location.py:67: in test_location_init
    self.assertEqual(loc.point, GRAND_CENTRAL_POINT)
geopy/location.py:87: in point
    return self._point if self._point != (None, None, None) else None
geopy/point.py:269: in __ne__
    return not (self == other)
geopy/point.py:264: in __eq__
    if not isinstance(other, collections.Iterable):
E   AttributeError: module 'collections' has no attribute 'Iterable'
_________________ LocationTestCase.test_location_is_picklable __________________
test/test_location.py:183: in test_location_is_picklable
    self.assertEqual(loc, loc_unp)
geopy/location.py:136: in __eq__
    self._point == other._point and
geopy/point.py:264: in __eq__
    if not isinstance(other, collections.Iterable):
E   AttributeError: module 'collections' has no attribute 'Iterable'
_____________________ LocationTestCase.test_location_iter ______________________
test/test_location.py:91: in test_location_iter
    self.assertEqual(loc.point, GRAND_CENTRAL_POINT)
geopy/location.py:87: in point
    return self._point if self._point != (None, None, None) else None
geopy/point.py:269: in __ne__
    return not (self == other)
geopy/point.py:264: in __eq__
    if not isinstance(other, collections.Iterable):
E   AttributeError: module 'collections' has no attribute 'Iterable'
______________________ LocationTestCase.test_location_ne _______________________
test/test_location.py:153: in test_location_ne
    self.assertNotEqual(loc1, loc2)
geopy/location.py:141: in __ne__
    return not (self == other)
geopy/location.py:136: in __eq__
    self._point == other._point and
geopy/point.py:264: in __eq__
    if not isinstance(other, collections.Iterable):
E   AttributeError: module 'collections' has no attribute 'Iterable'
_____________________ LocationTestCase.test_location_point _____________________
test/test_location.py:75: in test_location_point
    self.assertEqual(loc.point, GRAND_CENTRAL_POINT)
geopy/location.py:87: in point
    return self._point if self._point != (None, None, None) else None
geopy/point.py:269: in __ne__
    return not (self == other)
geopy/point.py:264: in __eq__
    if not isinstance(other, collections.Iterable):
E   AttributeError: module 'collections' has no attribute 'Iterable'
________ PointTestCase.test_point_comparison_does_not_raise_exceptions _________
test/test_point.py:319: in test_point_comparison_does_not_raise_exceptions
    self.assertFalse(point == number)
geopy/point.py:264: in __eq__
    if not isinstance(other, collections.Iterable):
E   AttributeError: module 'collections' has no attribute 'Iterable'
_____________ PointTestCase.test_point_comparison_ignores_strings ______________
test/test_point.py:358: in test_point_comparison_ignores_strings
    self.assertFalse(point == "123")
geopy/point.py:264: in __eq__
    if not isinstance(other, collections.Iterable):
E   AttributeError: module 'collections' has no attribute 'Iterable'
______________ PointTestCase.test_point_comparison_respects_lists ______________
test/test_point.py:346: in test_point_comparison_respects_lists
    self.assertTrue(l_eq == point)
geopy/point.py:264: in __eq__
    if not isinstance(other, collections.Iterable):
E   AttributeError: module 'collections' has no attribute 'Iterable'
____________ PointTestCase.test_point_comparison_with_empty_values _____________
test/test_point.py:328: in test_point_comparison_with_empty_values
    self.assertFalse(point_nonempty in empty_values)
geopy/point.py:264: in __eq__
    if not isinstance(other, collections.Iterable):
E   AttributeError: module 'collections' has no attribute 'Iterable'
_________________________ PointTestCase.test_point_eq __________________________
test/test_point.py:301: in test_point_eq
    self.assertEqual(
geopy/point.py:264: in __eq__
    if not isinstance(other, collections.Iterable):
E   AttributeError: module 'collections' has no attribute 'Iterable'
____________________ PointTestCase.test_point_from_iterable ____________________
test/test_point.py:109: in test_point_from_iterable
    self.assertEqual(Point(1, 2, 3), Point([1, 2, 3]))
geopy/point.py:264: in __eq__
    if not isinstance(other, collections.Iterable):
E   AttributeError: module 'collections' has no attribute 'Iterable'
_____________________ PointTestCase.test_point_from_string _____________________
test/test_point.py:81: in test_point_from_string
    self.assertEqual(Point("41.5;-81.0"), (41.5, -81.0, 0.0))
geopy/point.py:264: in __eq__
    if not isinstance(other, collections.Iterable):
E   AttributeError: module 'collections' has no attribute 'Iterable'
____________________ PointTestCase.test_point_is_picklable _____________________
test/test_point.py:368: in test_point_is_picklable
    self.assertEqual(point, point_unp)
geopy/point.py:264: in __eq__
    if not isinstance(other, collections.Iterable):
E   AttributeError: module 'collections' has no attribute 'Iterable'
_________________________ PointTestCase.test_point_ne __________________________
test/test_point.py:311: in test_point_ne
    Point(self.lat, self.lon, self.alt) !=
geopy/point.py:269: in __ne__
    return not (self == other)
geopy/point.py:264: in __eq__
    if not isinstance(other, collections.Iterable):
E   AttributeError: module 'collections' has no attribute 'Iterable'

See https://docs.python.org/3.9/whatsnew/3.9.html#removed

"The abstract base classes in collections.abc no longer are exposed in the regular collections module. This will help create a clearer distinction between the concrete classes and the abstract base classes."




For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01161364-python-geopy/

For all our attempts to build python-geopy with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-geopy/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Karthikeyan Singaravelan 2020-01-22 12:41:01 UTC

Upstream issue : https://github.com/geopy/geopy/issues/377 . As per discussion seems to be fixed with https://github.com/geopy/geopy/pull/335

Comment 2 Ben Cotton 2020-02-11 17:28:56 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 32 development cycle.
Changing version to 32.

Comment 3 Elliott Sales de Andrade 2020-02-13 10:58:40 UTC

PR#390 seems a better bet since it's for the v1 branch.

Comment 4 Miro Hrončok 2020-02-28 09:08:57 UTC

In Python 3.9.0a4 we have managed to revert the change that disables importing abstract base classes (collections.abc) directly form the regular collections module. It was reverted to ease transition for projects that did not yet actually dropped support for Python 2.7. The removal is scheduled for Python 3.10 instead.

We are mass closing all the bug reports about build failures that were caused by this. Expect a new Bugzilla report in case this package fails to build with Python 3.9 for a different reason as well.

In case you haven't done this already, we highly recommend to talk to your upstream and get this fixed anyway, because this will return in Python 3.10 and Python upstream is very unlikely to postpone this once more. In case you've already done that, thank you (this message is mass posted to all the relevant Bugzillas).

Note You need to log in before you can comment on or make changes to this bug.