Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1793476 - fail2ban fails to build with Python 3.9: imports abc from collections
Summary: fail2ban fails to build with Python 3.9: imports abc from collections
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: Fedora
Classification: Fedora
Component: fail2ban
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Orion Poplawski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON39
TreeView+ depends on / blocked
 
Reported: 2020-01-21 12:38 UTC by Miro Hrončok
Modified: 2020-02-28 09:08 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-02-28 09:08:19 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github fail2ban fail2ban issues 2610 0 None open fail2ban doesn't work with python 3.9 2020-02-27 05:01:49 UTC
Python 39482 0 None None None 2020-01-29 04:03:51 UTC

Description Miro Hrončok 2020-01-21 12:38:46 UTC 
fail2ban fails to build with Python 3.9.0a2.

+ /usr/bin/python3 bin/fail2ban-testcases --verbosity=2 --no-network
Fail2ban 0.11.1 test suite. Python 3.9.0a2 (default, Dec 19 2019, 00:00:00) [GCC 9.2.1 20190827 (Red Hat 9.2.1-1)]. Please wait...
Traceback (most recent call last):
  File "/builddir/build/BUILD/fail2ban-0.11.1/bin/fail2ban-testcases", line 61, in <module>
    tests = gatherTests(regexps, opts)
  File "./fail2ban/tests/utils.py", line 373, in gatherTests
    from . import clientreadertestcase
  File "./fail2ban/tests/clientreadertestcase.py", line 34, in <module>
    from ..client.jailreader import JailReader, extractOptions, splitWithOptions
  File "./fail2ban/client/jailreader.py", line 34, in <module>
    from .actionreader import ActionReader
  File "./fail2ban/client/actionreader.py", line 31, in <module>
    from ..server.action import CommandAction
  File "./fail2ban/server/action.py", line 33, in <module>
    from collections import MutableMapping
ImportError: cannot import name 'MutableMapping' from 'collections' (/usr/lib64/python3.9/collections/__init__.py)

See https://docs.python.org/3.9/whatsnew/3.9.html#removed

"The abstract base classes in collections.abc no longer are exposed in the regular collections module. This will help create a clearer distinction between the concrete classes and the abstract base classes."



For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01170483-fail2ban/

For all our attempts to build fail2ban with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/fail2ban/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.
Comment 1 Orion Poplawski 2020-01-21 13:58:57 UTC 
Amazingly (sadly) enough, fail2ban still is run through 2to3 for python 3 support.  Is this something that 2to3 reasonably should be expected to be able to support?
Comment 2 Miro Hrončok 2020-01-21 14:31:59 UTC 
> Is this something that 2to3 reasonably should be expected to be able to support?

I would say so.
Comment 3 Orion Poplawski 2020-01-29 04:03:51 UTC 
Filed against 2to3 as well then.
Comment 4 Ben Cotton 2020-02-11 17:23:45 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 32 development cycle.
Changing version to 32.
Comment 5 Miro Hrončok 2020-02-28 09:08:19 UTC 
In Python 3.9.0a4 we have managed to revert the change that disables importing abstract base classes (collections.abc) directly form the regular collections module. It was reverted to ease transition for projects that did not yet actually dropped support for Python 2.7. The removal is scheduled for Python 3.10 instead.

We are mass closing all the bug reports about build failures that were caused by this. Expect a new Bugzilla report in case this package fails to build with Python 3.9 for a different reason as well.

In case you haven't done this already, we highly recommend to talk to your upstream and get this fixed anyway, because this will return in Python 3.10 and Python upstream is very unlikely to postpone this once more. In case you've already done that, thank you (this message is mass posted to all the relevant Bugzillas).
Note You need to log in before you can comment on or make changes to this bug.