Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1795954 - python-colcon-core fails to build with Python 3.9: DeprecationWarning in %check treated as error
Summary: python-colcon-core fails to build with Python 3.9: DeprecationWarning in %che...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-colcon-core
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Scott K Logan
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1775852
Blocks: PYTHON39
TreeView+ depends on / blocked
 
Reported: 2020-01-29 10:16 UTC by Miro Hrončok
Modified: 2020-04-15 22:51 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-04-15 22:51:32 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github colcon colcon-core pull 285 0 None closed convert coroutines into tasks for Python 3.8 2020-04-13 23:50:27 UTC

Description Miro Hrončok 2020-01-29 10:16:48 UTC
python-colcon-core fails to build with Python 3.9.0a3.

3 tests fail with:

            finally:
                # read potential exceptions to avoid asyncio errors
>               for task in done:
E               UnboundLocalError: local variable 'done' referenced before assignment
colcon_core/subprocess.py:183: UnboundLocalError

Seems like this happens due to unexpected exception triggering the finally block:

>               done, _ = await asyncio.wait(callbacks, return_when=ALL_COMPLETED)
...
E           DeprecationWarning: The explicit passing of coroutine objects to asyncio.wait() is deprecated since Python 3.8, and scheduled for removal in Python 3.11.

The test suite seems to consider DeprecationWarning errors.


For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01198210-python-colcon-core/

For all our attempts to build python-colcon-core with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-colcon-core/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Ben Cotton 2020-02-11 17:23:17 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 32 development cycle.
Changing version to 32.

Comment 2 Miro Hrončok 2020-03-16 13:47:12 UTC
Scott, could you please have look and report this upstream if needed? Thanks.

Comment 3 Scott K Logan 2020-04-13 23:50:27 UTC
This was fixed in colcon_core 0.5.0. I'll prioritize updating the package.


Note You need to log in before you can comment on or make changes to this bug.