Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 179709 - Review Request: dap-hdf4_handler - HDF4 data handler for the OPeNDAP Data server
Summary: Review Request: dap-hdf4_handler - HDF4 data handler for the OPeNDAP Data server
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ed Hill
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT 179707
TreeView+ depends on / blocked
 
Reported: 2006-02-02 10:03 UTC by Patrice Dumas
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-02-26 02:03:37 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Patrice Dumas 2006-02-02 10:03:02 UTC
SRPM Name or Url: http://www.environnement.ens.fr/perso/dumas/fc-srpms/hdf4_handler-3.5.0-1.src.rpm
Description: 

This is the hdf4 data handler for our data server. It reads HDF4 and HDF-EOS
files and returns DAP responses that are compatible with DAP2 and the
dap-server 3.5 software.

Comment 1 Patrice Dumas 2006-02-02 10:08:32 UTC
This bug depends on #179707, but circular dependencies are not allowed.

Comment 2 Ed Hill 2006-02-20 03:25:30 UTC
Hi Patrice, heres a review:

good:
 + license is acceptable for FE and included 
 + source matches upstream
 + spec file is clean and has no obviuous errors
 + builds in mock on FC4
 + dir ownership and permissions look good
 + very simple package

needswork:
 - please re-name it to "dap-hdf4_handler" or similar
 - license is LGPL not GPL


Comment 4 Ed Hill 2006-02-20 13:53:30 UTC
Both items from comment #2 are fixed so its APPROVED.

Comment 5 Patrice Dumas 2006-02-26 02:03:37 UTC
Ed, thanks for all the reviews, and sorry for the dap-server mess... Everything
builds in FC3 and FC4, and I reported upstream the issues (including the
HTML::Parser issue) and they're working on it.

Comment 6 Christian Iseli 2006-10-18 13:15:28 UTC
Normalize summary field for easy parsing


Note You need to log in before you can comment on or make changes to this bug.