Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1811306 - python-notebook fails to build with Python 3.9: encoding parameter of json.loads() has been removed
Summary: python-notebook fails to build with Python 3.9: encoding parameter of json.lo...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-notebook
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Miro Hrončok
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON39
TreeView+ depends on / blocked
 
Reported: 2020-03-07 11:52 UTC by Miro Hrončok
Modified: 2020-03-16 18:47 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-03-16 18:47:57 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github jupyter notebook issues 5165 0 None closed Encoding parameter to json.loads is deprecated and will be removed in Python 3.9 2020-03-16 18:31:49 UTC
Github jupyter notebook pull 5174 0 None closed Remove deprecated encoding parameter for Python 3.9 compatibility. 2020-03-16 18:31:49 UTC

Description Miro Hrončok 2020-03-07 11:52:37 UTC
python-notebook fails to build with Python 3.9.0a4.

Traceback (most recent call last):
  File "/builddir/build/BUILD/notebook-6.0.2/notebook/tests/test_gateway.py", line 178, in test_gateway_get_kernelspecs
    content = json.loads(response.content.decode('utf-8'), encoding='utf-8')
  File "/usr/lib64/python3.9/json/__init__.py", line 359, in loads
    return cls(**kw).decode(s)
TypeError: __init__() got an unexpected keyword argument 'encoding'


See https://docs.python.org/3.9/whatsnew/3.9.html#removed

"The encoding parameter of json.loads() has been removed. As of Python 3.1, it was deprecated and ignored; using it has emitted a DeprecationWarning since Python 3.8."


For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01296959-python-notebook/

For all our attempts to build python-notebook with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-notebook/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 2 Miro Hrončok 2020-03-16 18:47:57 UTC
Fix backported, pushed to dist git.


Note You need to log in before you can comment on or make changes to this bug.