Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1821305 - Review Request: zgrab2 - Application Layer Scanner
Summary: Review Request: zgrab2 - Application Layer Scanner
Keywords:
Status: POST
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1819317
Blocks: FE-SECLAB
TreeView+ depends on / blocked
 
Reported: 2020-04-06 14:22 UTC by Fabian Affolter
Modified: 2020-06-22 20:42 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
zebob.m: fedora-review+

Attachments (Terms of Use)

Description Fabian Affolter 2020-04-06 14:22:40 UTC 
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/zgrab2.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/zgrab2-0.1.5-1.fc31.src.rpm

Project URL: https://github.com/zmap/zgrab2

Description:
Go Application Layer Scanner.

Koji scratch build:
fails due to missing dependencies

rpmlint output:
$ rpmlint zgrab2-0.1.5-1.fc31.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint zgrab2-0.1.5-1.fc31.x86_64.rpm 
zgrab2.x86_64: W: no-manual-page-for-binary http
zgrab2.x86_64: W: no-manual-page-for-binary zgrab2
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Fedora Account System Username: fab
Comment 1 Robert-André Mauchin 🐧 2020-06-19 18:56:47 UTC 
 - Bump to 0.1.7

 - License seems co be ISC and ASL 2:0:

License:        ISC and ASL 2.0

 - There's an API mismatch:

# github.com/zmap/zgrab2
_build/src/github.com/zmap/zgrab2/utility.go:52:39: parser.ParseCommandLine undefined (type *flags.Parser has no field or method ParseCommandLine)
/usr/lib/golang/pkg/tool/linux_amd64/buildid -w $WORK/b168/_pkg_.a # internal


Seems to be linked to zflags. 1.4.0-beta.1 has ParseCommandLine.



Zcrypto needs updating too:

# github.com/zmap/zgrab2/modules/http
_build/src/github.com/zmap/zgrab2/modules/http/scanner.go:229:31: undefined: "github.com/zmap/zcrypto/tls".SigAndHash


After all this is updated, it works:

 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved. Please fix the License before import.
Comment 2 Gwyn Ciesla 2020-06-22 20:42:20 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/zgrab2
Note You need to log in before you can comment on or make changes to this bug.