Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 182319 - Review Request: anjuta-gdl
Summary: Review Request: anjuta-gdl
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: John Mahowald
QA Contact: Fedora Package Reviews List
Depends On:
Blocks: FE-ACCEPT 182320
TreeView+ depends on / blocked
Reported: 2006-02-21 20:25 UTC by Paul F. Johnson
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2006-07-08 21:54:37 UTC
Type: ---

Attachments (Terms of Use)
Proposed patch to the spec (deleted)
2006-04-23 07:18 UTC, Ralf Corsepius
no flags Details | Diff
spec patch (CVS) (deleted)
2006-07-09 12:11 UTC, Michael Schwendt
no flags Details | Diff

Description Paul F. Johnson 2006-02-21 20:25:03 UTC
Spec Name or Url:
SRPM Name or Url:

This package contains components and libraries that are intended to be
shared between GNOME development tools, including gnome-build and anjuta2.

It has been renamed anjuta-gdl (by me) as there is already a package called gdl which is not part of the gnome dev tools

Comment 1 John Mahowald 2006-02-26 21:47:11 UTC
Build failed on rawhide. 

checking for libxml-2.0 >= 2.2.8... Package libxml-2.0 was not found in the
pkg-config search path.

Also, the spec has many Requires and no BuildRequires. Really it should be the
other way around, with *-devel packages in BuildRequires rpm will figure out the

* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)

Comment 3 Paul F. Johnson 2006-04-13 23:28:27 UTC

Comment 4 John Mahowald 2006-04-22 22:33:18 UTC
Close! Needs libxml2-devel though. Still don't build:

checking for libxml-2.0 >= 2.2.8... Package libxml-2.0 was not found in the
pkg-config search path.

This should be the case for the others, change all your BuildRequires to *-devel.

Also, use the %find_lang macro for locales.

Comment 5 Paul F. Johnson 2006-04-22 22:51:58 UTC
Spec Name or Url:
SRPM Name or Url:

%find_lang reports that there is nothing to find.
Changed the BRs to -devel
Added a couple of Reqs
Fixed a small fault that caused a problem on the x86 box for no apparent reason!

Comment 6 Ralf Corsepius 2006-04-23 07:16:01 UTC
Several issues:

1. The reason for your problems with find_lang is you not correctly using

You will want something similar to this:
%find_lang gdl-1
%files -f gdl-1.lang

2. AFAIS, this package doesn't need nor use libglade. 
It seems to use libglade2.

3. I don't see why this package should explicitly
Requires: gtk2

4. Use %configure --disable-shared instead removing *.as

5. Terminating 'dot' at the end of Summary-lines

1+2 are blockers, 3+4 are minor issues, 5 is FE-stylishness.

On top of that, I am pretty sure the *-devel package misses many deps on other
*-devel packages.

Comment 7 Ralf Corsepius 2006-04-23 07:18:01 UTC
Created attachment 128125 [details]
Proposed patch to the spec

Comment 8 Paul F. Johnson 2006-04-23 13:17:50 UTC
Spec Name or Url:
SRPM Name or Url:

Fixes as proposed

Comment 9 John Mahowald 2006-04-23 21:35:24 UTC

- rpmlint checks return:
W: anjuta-gdl one-line-command-in-%post /sbin/ldconfig
W: anjuta-gdl one-line-command-in-%postun /sbin/ldconfig
W: anjuta-gdl-debuginfo objdump-failed
E: anjuta-gdl-debuginfo script-without-shellbang
E: anjuta-gdl-debuginfo script-without-shellbang
E: anjuta-gdl-devel only-non-binary-in-usr-lib
W: anjuta-gdl-devel no-documentation

None of these are blockers.

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- locales handled by %find_lang
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r 


Comment 10 Michael Schwendt 2006-07-08 12:11:55 UTC
* Missing -devel package dependencies! Notice the "Requires" line
in the pkgconfig file. You have a broken pkgconfig dependency chain
there. The C headers also include missing headers. Add the required
-devel packages as dependencies of your anjuta-gdl-devel package.

* Prefer "Requires: %{name} = %{version}-%{release} in your -devel
package, so main package and -devel package are in sync as much as

> post/postun ldconfig ok

When there's no scriptlet body, prefer:

%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig

That adds automatic dependencies on /sbin/ldconfig, too.
Else, add the missing dependencies manually:

Requires(post): /sbin/ldconfig
Requires(postun): /sbin/ldconfig

Comment 11 Paul F. Johnson 2006-07-08 16:33:13 UTC
#10, thanks. I'll get that fixed tonight and it should be out for the next push
(probably Sunday)

Comment 12 Michael Schwendt 2006-07-09 12:11:24 UTC
Created attachment 132128 [details]
spec patch (CVS)

Not fixed yet. Let me try to rephrase:

Your anjuta-gdl-devel package is missing several "Requires". You
need to make it depend on other -devel package, which are needed by
/usr/lib/pkgconfig/gdl-1.0.pc (notice the Requires line in there!)
and the C headers (notice which files from other packages they

To find the other packages which provide the pkgconfig files, you
can do, for example:

$ repoquery --whatprovides /usr/lib/pkgconfig/libbonoboui-2.0.pc
/usr/lib/pkgconfig/libgnome-2.0.pc /usr/lib/pkgconfig/gtk+-2.0.pc
/usr/lib/pkgconfig/libxml-2.0.pc /usr/lib/pkgconfig/libglade-2.0.pc

and then make your anjuta-gdl-devel package "Requires" these packages.
See attached patch.

The change related to /sbin/ldconfig was an "either or". With "-p" the
dependency on /sbin/ldconfig is _automatic_.

Comment 13 Paul F. Johnson 2006-07-09 12:20:45 UTC
Thanks for the clarification. 0.6.1-4 should be in the next push

Note You need to log in before you can comment on or make changes to this bug.