*** Bug 1117223 has been marked as a duplicate of this bug. ***

Please use a link to raw spec file to properly get it downloadable.
E.g. https://raw.githubusercontent.com/andreamtp/kronometer/master/kronometer.spec

> Release: 0%{?dist}
Please start with value 1, also in %changelog.

Please follow the guidelines to get sponsored as a packager.
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group

Updated according the comments above:

Spec URL: https://raw.githubusercontent.com/andreamtp/kronometer/master/kronometer.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/andreamtp/kronometer/fedora-rawhide-x86_64/01366326-kronometer/kronometer-2.2.3-1.fc33.src.rpm


Kronometer is a stopwatch application. Kronometer is free software and it's released under the GPLv2 license.
Fedora Account System Username: andreamtp

I was looking for a stopwatch for KDE and found kronometer was missing in Fedora, so I've packaged.
I've already done some packaging for persona use, but this is my rpm for Fedora.

COPR builds of the packages:
https://copr.fedorainfracloud.org/coprs/andreamtp/kronometer/

As I'm asked, I can't sponsor you because I'm not in the sponsors group. You need to look for another mentor with the relevant responsibilities.

At a first glance, the specfile looks reasonable to me. Just please also write your name in the changelog and not only the e-mail address.

I have sponsored Andrea. Benvenuto! (Welcome!) Please read https://fedoraproject.org/wiki/Join_the_package_collection_maintainers carefully and follow the process.

I am fluent in Italian (it's the language of my citizenship after all), so if you have any questions you have to ask me, feel free to ask them in Italian if it is easier for you. (Though I guess that as a Red Hat employee, you are probably also used to communicating in English.)

Raphael, can you complete the formal review? (You can approve the package now that the contributor is sponsored.)

Kevin, did you run fedora-review?

Well, FAS name seems to be andreamtp as given in the COPR links.

Generally, are you interested in review swap?

(In reply to Kevin Kofler from comment #6)
> At a first glance, the specfile looks reasonable to me. Just please also
> write your name in the changelog and not only the e-mail address.

Updated according the comments above:

Spec URL: https://raw.githubusercontent.com/andreamtp/kronometer/master/kronometer.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/andreamtp/kronometer/fedora-rawhide-x86_64/01428211-kronometer/kronometer-2.2.3-1.fc33.src.rpm


Kronometer is a stopwatch application. Kronometer is free software and it's released under the GPLv2 license.
Fedora Account System Username: andreamtp

I was looking for a stopwatch for KDE and found kronometer was missing in Fedora, so I've packaged.
I've already done some packaging for persona use, but this is my rpm for Fedora.

COPR builds of the packages:
https://copr.fedorainfracloud.org/coprs/andreamtp/kronometer/
 
> I have sponsored Andrea. Benvenuto! [...]
Thank you very much for the sponsorship and for the welcome!

(In reply to Raphael Groner from comment #7)
> Kevin, did you run fedora-review?

No, I didn't, I would have posted the output if I did.

To get a first impression of the quality of a specfile, I tend to trust my eyes more than some tool. :-) But of course, if I am doing a complete formal review, I run fedora-review next, before giving the final approval.

Raphael, are you going to run fedora-review, since you took the review?

E.g., what my pedantic eyes catch is the inconsistent alignment here:
BuildRequires: desktop-file-utils
BuildRequires: libappstream-glib
BuildRequires:  extra-cmake-modules

BuildRequires:  cmake(Qt5Core) >= 5.9.0
…
(The first 2 BuildRequires have 1 space after the colon, all the others have 2 spaces.)

That is not something I would fail a review for (because the users of the package won't even notice), but if I were the maintainer of the package, I would have the instant urge to fix this. :-)

(In reply to Kevin Kofler from comment #10)
> E.g., what my pedantic eyes catch is the inconsistent alignment here:
> BuildRequires: desktop-file-utils
> BuildRequires: libappstream-glib
> BuildRequires:  extra-cmake-modules

Eheh, fair enough: fixed.

Spec URL: https://raw.githubusercontent.com/andreamtp/kronometer/master/kronometer.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/andreamtp/kronometer/fedora-rawhide-x86_64/01428272-kronometer/kronometer-2.2.3-1.fc33.src.rpm

> Raphael, are you going to run fedora-review, since you took the review?

>> Raphael, can you complete the formal review? (You can approve the package now that the contributor is sponsored.)

Well, I thought you intent me to do so. Please feel free to approve.

> Well, I thought you intent me to do so.

That was my intention, actually. I was just surprised that you have not posted fedora-review output yet.

TBH I fail to find the time to do the official review in near future, sorry.

I'll take the review then, I hope I'll get it done soon. If I take too long, please remind me. :-)

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.