Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 183097 - Review Request: rogue - text-based adventure game
Summary: Review Request: rogue - text-based adventure game
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: John Mahowald
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-02-26 05:45 UTC by Wart
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-08-29 13:06:09 UTC
Type: ---
Embargoed:
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Wart 2006-02-26 05:45:02 UTC 
Spec Name or Url: http://www.kobold.org/~wart/fedora/rogue.spec
SRPM Name or Url: http://www.kobold.org/~wart/fedora/rogue-5.4.2-1.src.rpm
Description: 
Before DOOM, there were the Dungeons of DOOM.  This is the game that started an entire genre.
Comment 1 Wart 2006-02-26 05:49:30 UTC 
rogue is setgid 'games' so that everyone who runs the game can write to the high
score file.  This causes rpmlint to complain:

E: rogue non-standard-dir-perm /var/games/roguelike 0775
E: rogue non-standard-executable-perm /usr/bin/rogue 02755

I am inclined to ignore this.
Comment 2 John Mahowald 2006-03-10 05:05:01 UTC 
Good:

- rpmlint checks return:
E: rogue non-standard-dir-perm /var/games/roguelike 0775
E: rogue non-standard-executable-perm /usr/bin/rogue 02755
ignored as per comment 1.

- package meets naming guidelines
- package meets packaging guidelines
- license (BSD) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- .desktop  file
- runs :)

APPROVED
Comment 3 Wart 2006-03-13 05:13:27 UTC 
Imported and built.  Thanks!
Comment 4 John Mahowald 2006-08-29 13:06:09 UTC 
Assigning to me.
Comment 5 Wart 2007-10-15 18:54:59 UTC 
Package Change Request
======================
Package Name: rogue
New Branches: F-8
Comment 6 Kevin Fenzi 2007-10-15 20:37:22 UTC 
cvs done.
Note You need to log in before you can comment on or make changes to this bug.