Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1831130 - python-asynctest fails to build with Python 3.9: Incompatibilities in mock objects break the tests
Summary: python-asynctest fails to build with Python 3.9: Incompatibilities in mock ob...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-asynctest
Version: 33
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Georg Sauthoff
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1842112 (view as bug list)
Depends On:
Blocks: F33FTBFS F33FailsToInstall PYTHON39
TreeView+ depends on / blocked
 
Reported: 2020-05-04 17:16 UTC by Miro Hrončok
Modified: 2020-09-08 20:00 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-09-08 20:00:12 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Miro Hrončok 2020-05-04 17:16:38 UTC 
python-asynctest fails to build with Python 3.9.0a6.

Traceback (most recent call last):
  File "/builddir/build/BUILD/asynctest-0.13.0/test/test_mock.py", line 975, in test_patch_is_enabled_when_running_decorated_coroutine
    self.assertTrue(run_coroutine(a_coroutine()))
  File "/builddir/build/BUILD/asynctest-0.13.0/test/utils.py", line 9, in run_coroutine
    return loop.run_until_complete(coroutine)
  File "/usr/lib64/python3.9/asyncio/base_events.py", line 642, in run_until_complete
    return future.result()
  File "/builddir/build/BUILD/asynctest-0.13.0/asynctest/mock.py", line 995, in patched_generator
    return (yield from patched_factory(*args, **kwargs))
  File "/builddir/build/BUILD/asynctest-0.13.0/asynctest/mock.py", line 1044, in __next__
    self._stop_global_patchings()
  File "/builddir/build/BUILD/asynctest-0.13.0/asynctest/mock.py", line 1032, in _stop_global_patchings
    if _is_started(patching):
  File "/builddir/build/BUILD/asynctest-0.13.0/asynctest/mock.py", line 124, in _is_started
    return unittest.mock._is_started(patching)
AttributeError: module 'unittest.mock' has no attribute '_is_started'

(And many more...)


For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01365446-python-asynctest/

For all our attempts to build python-asynctest with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-asynctest/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.
Comment 1 Miro Hrončok 2020-05-25 13:01:10 UTC 
This comment is mass posted to all bugs blocking the Python 3.9 tracker, sorry if it is not 100 % relevant. When in doubt, please ask.


The Python 3.9 rebuild is in progress in a Koji side tag.

If you fix this bug, please don't rebuild the package in regular rawhide, but do it in the side tag with:

    $ fedpkg build --target=f33-python

The rebuild is progressing slowly and it is possible this package won't have all the required build dependencies yet. If that's the case, please just leave the fix committed and pushed and we will eventually rebuild it for you.

You are not asked to go and try rebuild all the missing dependencies yourself. If you know there is a bootstrap loop in the dependencies, let me know and we can untangle it together.

If you want to test your fix or reproduce the failure, you can still use the Copr repo mentioned in the initial comment of this bug: https://copr.fedorainfracloud.org/coprs/g/python/python3.9/
Comment 2 Miro Hrončok 2020-05-29 07:11:17 UTC 
Python 3.9 update: The f33-python side tag is currently being merged.

New builds in f33-python are no longer possible, but python3 is not yet updated to Python 3.9 in rawhide. You can check when Python is Python 3.9 with:

    $ koji wait-repo f33-build --build python3.9-3.9.0~b1-3.fc3

And build the packages normally after that.
Comment 3 Miro Hrončok 2020-06-01 11:12:31 UTC 
*** Bug 1842112 has been marked as a duplicate of this bug. ***
Comment 4 Igor Raits 2020-06-01 14:18:25 UTC 
Hello,

This is the first reminder (step 3 from https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs).
Comment 5 Igor Raits 2020-06-01 14:23:09 UTC 
Sorry, found yet another bug in automated handling.
Comment 6 Georg Sauthoff 2020-06-21 16:21:27 UTC 
Created upstream issue: https://github.com/Martiusweb/asynctest/issues/151
Comment 7 Ben Cotton 2020-08-11 13:22:40 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 33 development cycle.
Changing version to 33.
Comment 8 Miro Hrončok 2020-08-22 10:30:41 UTC 
Hello. This comment is mass posted to all 16 bugzillas for packages that failed to rebuild with Python 3.9 (and, in most cases, also fail to install on Fedora 33 and 34). Apologies if some of the suggestions or questions don't apply 100%.

Fedora 33 Beta Freeze starts next week on Tuesday, 2020-08-25. I haven't spammed this bugzilla because it is in ASSIGNED, or I've seen upstream has been notified.

Please consider what to do here. Is this failure critical? For example, can a test be temporarily skipped to make this package build? Is it possible to fix or workaround the failure before Fedora 33 Beta? Or before Fedora 33 Final? If not, would it make sense to retire the package (even temporarily) before the release to unblock updates from Fedora 31 or Fedora 32?

In case you need any assistance with a Python-related problem with the build, don't hesitate to let me know and I'll try to have a look.

Thank you!
Comment 9 Charalampos Stratakis 2020-09-07 17:48:50 UTC 
Upstream doesn't seem responsive on the latest issue with Python 3.9 and also "$ repoquery --repo=rawhide{,-source} --whatrequires python3-asynctest --recursive " doesn't produce any output. Maybe it would be better to retire the package if nothing else requires it.
Comment 10 Georg Sauthoff 2020-09-07 21:52:42 UTC 
Charalampos, to retire the package is exactly my plan I detailed in another comment:

https://bugzilla.redhat.com/show_bug.cgi?id=1871594#c2

I'll execute the necessary steps in the next days.
Comment 11 Georg Sauthoff 2020-09-08 20:00:12 UTC 
It's now retired: https://bugzilla.redhat.com/show_bug.cgi?id=1871594#c4
Note You need to log in before you can comment on or make changes to this bug.