Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1832610 - Review Request: python-pcodedmp - VBA p-code disassembler
Summary: Review Request: python-pcodedmp - VBA p-code disassembler
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1779427 1811089
TreeView+ depends on / blocked
 
Reported: 2020-05-06 21:39 UTC by Robert Scheck
Modified: 2020-05-24 01:07 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-05-17 02:42:28 UTC
Type: Bug
Embargoed:
zbyszek: fedora-review+

Attachments (Terms of Use)

Description Robert Scheck 2020-05-06 21:39:35 UTC 
Spec URL: https://labs.linuxnetz.de/bugzilla/python-pcodedmp.spec
SRPM URL: https://labs.linuxnetz.de/bugzilla/python-pcodedmp-1.2.6-1.src.rpm
Description: Macros written in VBA (Visual Basic for Applications; the macro programming language used in Microsoft Office) exist in three different executable forms, each of which can be what is actually executed at run time, depending on the circumstances: Source code, p-code and execodes.
Since most of the time it is the p-code that determines what exactly a macro would do (even if neither source code, nor execodes are present), pcodedmp is a Python library and command line tool to display it.
Fedora Account System Username: robert
Comment 1 Zbigniew Jędrzejewski-Szmek 2020-05-07 09:15:09 UTC 
+ package name is OK
+ latest version
+ license is acceptable for Fedora (GPLv3+)
+ license is specified correctly
+ builds and installs OK (with --with bootstrap)
+ BR/R/P look OK

rpmlint:
python3-pcodedmp.noarch: E: useless-provides python-pcodedmp
python3-pcodedmp.noarch: E: useless-provides python38-pcodedmp
Oh, this is because the Provide is duplicated. Seems to be some bug in the 
tooling. Doesn't matter anyway.

python3-pcodedmp.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pcodedmp/pcodedmp.py 644 /usr/bin/env python
Doesn't matter, but consider fixing this if you have time ;)

Package is APPROVED.
Comment 2 Robert Scheck 2020-05-07 12:46:01 UTC 
Thank you for the review, SCM requests have been filed.
Comment 3 Fedora Update System 2020-05-08 20:58:07 UTC 
FEDORA-EPEL-2020-4e70fac79f has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-4e70fac79f
Comment 4 Fedora Update System 2020-05-08 20:59:10 UTC 
FEDORA-EPEL-2020-ab70a91a78 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-ab70a91a78
Comment 5 Fedora Update System 2020-05-08 21:00:13 UTC 
FEDORA-2020-d6e9f805cf has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-d6e9f805cf
Comment 6 Fedora Update System 2020-05-08 22:23:12 UTC 
FEDORA-2020-23790ce53d has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-23790ce53d
Comment 7 Fedora Update System 2020-05-09 03:30:46 UTC 
FEDORA-EPEL-2020-ab70a91a78 has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-ab70a91a78

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 8 Fedora Update System 2020-05-09 04:16:44 UTC 
FEDORA-EPEL-2020-4e70fac79f has been pushed to the Fedora EPEL 7 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-4e70fac79f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 9 Fedora Update System 2020-05-09 04:38:51 UTC 
FEDORA-2020-d6e9f805cf has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-d6e9f805cf \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-d6e9f805cf

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 10 Fedora Update System 2020-05-09 04:56:28 UTC 
FEDORA-2020-1d32add79f has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-1d32add79f
Comment 11 Itamar Reis Peixoto 2020-05-09 04:59:19 UTC 
I think you was missed f32, looks good.
Comment 12 Fedora Update System 2020-05-09 06:41:51 UTC 
FEDORA-2020-23790ce53d has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-23790ce53d \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-23790ce53d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 13 Robert Scheck 2020-05-09 11:45:22 UTC 
Itamar, how did I miss F32? See comment #6 - there also was bootstrapping with buildroot override (and tests!)
Comment 14 Fedora Update System 2020-05-17 02:42:28 UTC 
FEDORA-2020-23790ce53d has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 15 Fedora Update System 2020-05-17 03:48:41 UTC 
FEDORA-2020-d6e9f805cf has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 16 Fedora Update System 2020-05-24 01:01:24 UTC 
FEDORA-EPEL-2020-ab70a91a78 has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 17 Fedora Update System 2020-05-24 01:07:16 UTC 
FEDORA-EPEL-2020-4e70fac79f has been pushed to the Fedora EPEL 7 stable repository.
If problem still persists, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.