Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1834231 - Review Request: ursa-major - fix install failure on Fedora 32
Summary: Review Request: ursa-major - fix install failure on Fedora 32
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 32
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR 1834130
TreeView+ depends on / blocked
 
Reported: 2020-05-11 10:52 UTC by Yuming Zhu
Modified: 2020-05-11 11:55 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-05-11 11:32:36 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Yuming Zhu 2020-05-11 10:52:04 UTC
Spec URL: https://github.com/azhuzhu/rpm-usra-major/blob/f32/ursa-major.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/2926/44362926/ursa-major-0.4.1-2.fc32.src.rpm
Description: this PR is to fix the failure caused by the lack of deps - BZ#1834130
Fedora Account System Username: julian8628
PR: https://src.fedoraproject.org/rpms/ursa-major/pull-request/5

Comment 1 Yuming Zhu 2020-05-11 10:55:34 UTC
This is my first request of review and I need to be sponsored, as I'm now the maintainer of ursa-major.

Comment 2 Yuming Zhu 2020-05-11 10:58:48 UTC
cc @qwan for review

Comment 3 Fabio Valentini 2020-05-11 11:25:29 UTC
Since this package already exists and you're already its maintainer, opening a Review Request (which is for new packages) is not the right avenue to do this, and you don't need a sponsor, since you're obviously already in the packager group.

For doing Pull Requests, I suggest going to https://src.fedoraproject.org/rpms/ursa-major and fork the package.
Do your changes in your fork, and then open a Pull Request for them, so somebody else can review the changes.

But I see you've already done that? https://src.fedoraproject.org/rpms/ursa-major/pull-request/5

I'm confused.

Comment 4 Qixiang Wan 2020-05-11 11:32:36 UTC
(In reply to Fabio Valentini from comment #3)
> Since this package already exists and you're already its maintainer, opening
> a Review Request (which is for new packages) is not the right avenue to do
> this, and you don't need a sponsor, since you're obviously already in the
> packager group.

Yep, review request is the workflow for onboarding a new package, I'm going to close this. Yuming is the new maintainer of ursa-major but he is not in packager group, so I can't give the package to him, I'll contact him for this.

Comment 5 Yuming Zhu 2020-05-11 11:55:12 UTC
(In reply to Fabio Valentini from comment #3)
> Since this package already exists and you're already its maintainer, opening
> a Review Request (which is for new packages) is not the right avenue to do
> this, and you don't need a sponsor, since you're obviously already in the
> packager group.
> 
> For doing Pull Requests, I suggest going to
> https://src.fedoraproject.org/rpms/ursa-major and fork the package.
> Do your changes in your fork, and then open a Pull Request for them, so
> somebody else can review the changes.
> 
> But I see you've already done that?
> https://src.fedoraproject.org/rpms/ursa-major/pull-request/5
> 
> I'm confused.

Yes, I'm able to fork the repo, but because I'm not in packager group, I cannot push commits into either my fork or upstream repo, I guess

Thanks!


Note You need to log in before you can comment on or make changes to this bug.