Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
  Note: Package contains %{pythonX_site(lib|arch)}/* in %files
  See: https://pagure.io/packaging-committee/issue/782
- Descriptions should end with a period
- Looks like that "Source0:" could be replace with %{pypi_source}

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD 3-clause "New" or "Revised" License", "Unknown or
     generated", "*No copyright* BSD (unspecified)". 268 files have unknown
     license. Detailed output of licensecheck in
     /home/fab/Documents/repos/reviews/1834932-python-
     google-i18n-address/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib/python3.8/site-
     packages/tests(python3-pure-protobuf, python3-ipmi, python3-netssh2),
     /usr/lib/python3.8/site-packages/tests/__pycache__(python3-ipmi,
     python3-netssh2)
[-]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[- ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-google-i18n-address-2.3.5-1.fc33.noarch.rpm
          python-google-i18n-address-2.3.5-1.fc33.src.rpm
python3-google-i18n-address.noarch: E: no-changelogname-tag
python3-google-i18n-address.noarch: W: no-documentation
python-google-i18n-address.src: W: description-shorter-than-summary
python-google-i18n-address.src: E: no-changelogname-tag
python-google-i18n-address.src: E: specfile-error error: bad date in %changelog: May Feb 12 2020 Paul Wouters <pwouters> - 2.3.5-1
2 packages and 0 specfiles checked; 3 errors, 2 warnings.




Rpmlint (installed packages)
----------------------------
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
python3-google-i18n-address.noarch: E: no-changelogname-tag
python3-google-i18n-address.noarch: W: invalid-url URL: https://pypi.python.org/pypi/google-i18n-address/ <urlopen error [Errno -2] Name or service not known>
python3-google-i18n-address.noarch: W: no-documentation
1 packages and 0 specfiles checked; 1 errors, 2 warnings.



Source checksums
----------------
https://files.pythonhosted.org/packages/source/g/google-i18n-address/google-i18n-address-2.3.5.tar.gz :
  CHECKSUM(SHA256) this package     : 7c6cd436e9abcdd69ea347d2e440d718019eed55e98b7078051f902a521f6fce
  CHECKSUM(SHA256) upstream package : 7c6cd436e9abcdd69ea347d2e440d718019eed55e98b7078051f902a521f6fce


Requires
--------
python3-google-i18n-address (rpmlib, GLIBC filtered):
    python(abi)
    python3.8dist(requests)



Provides
--------
python3-google-i18n-address:
    python-google-i18n-address
    python3-google-i18n-address
    python3.8-google-i18n-address
    python3.8dist(google-i18n-address)
    python3dist(google-i18n-address)



Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16
Command line :/usr/bin/fedora-review -b 1834932
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, Python
Disabled plugins: Haskell, Java, Perl, R, PHP, fonts, SugarActivity, C/C++, Ocaml
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Thanks for review. Issues resolved:

Spec URL: https://nohats.ca/ftp/python-google-i18n-address/python-google-i18n-address.spec
SRPM URL: https://nohats.ca/ftp/python-google-i18n-address/python-google-i18n-address-2.3.5-2.fc32.src.rpm
Description: This package contains a copy of Google’s i18n address metadata
repository that contains great data but comes with no uptime guarantees.

Contents of this package will allow you to programatically build address
forms that adhere to rules of a particular region or country, validate
local addresses and format them to produce a valid address label for
delivery.

The package also contains a Python interface for address validation.}

Fedora Account System Username: pwouters


rpmlint output:

python-google-i18n-address.src: W: spelling-error %description -l en_US uptime -> up time, up-time, suppertime
python-google-i18n-address.src: W: spelling-error %description -l en_US programatically -> grammatically, problematically, pragmatically
python3-google-i18n-address.noarch: W: spelling-error %description -l en_US uptime -> up time, up-time, suppertime
python3-google-i18n-address.noarch: W: spelling-error %description -l en_US programatically -> grammatically, problematically, pragmatically
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

Could you please add %{?python_provide:%python_provide python3-%{pypi_name}} for the Python 3 package before the import?

Other issues were addressed, package APPROVED.

I was too slow and now it won't init the repo. Could you unset and set the review flag again? I promise this time I'll pick it up right away :)

Set again.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-google-i18n-address

python-google-i18n-address-2.4.0-1.fc34 has been built