Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1835302 - Review Request: nodejs-pg-protocol - The postgres client/server binary protocol
Summary: Review Request: nodejs-pg-protocol - The postgres client/server binary protocol
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: nodejs-reviews 1835288
TreeView+ depends on / blocked
 
Reported: 2020-05-13 15:04 UTC by Tom Hughes
Modified: 2020-06-24 14:24 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-06-24 14:24:55 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+

Attachments (Terms of Use)

Description Tom Hughes 2020-05-13 15:04:35 UTC 
Spec URL: https://tomh.fedorapeople.org//nodejs-pg-protocol.spec
SRPM URL: https://tomh.fedorapeople.org//nodejs-pg-protocol-1.2.3-1.fc32.src.rpm

Description:
The postgres client/server binary protocol, implemented in TypeScript.
Comment 1 Tom Hughes 2020-05-13 15:05:52 UTC 
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=44450368
Comment 2 Robert-André Mauchin 🐧 2020-06-24 12:24:11 UTC 
 - Bump to 1.2.4

 - Build error:

+ /usr/bin/node -e 'require('\''./'\'')'
/var/tmp/rpm-tmp.BuwxTu: line 33: /usr/bin/node: No such file

   Add:

BuildRequires:  nodejs(engine)


This is due to nodejs-packaging dropping the nodejs engine as a Requires 20 days ago: https://src.fedoraproject.org/rpms/nodejs-packaging/c/021f0badabbe076a6e869e2ebdedfbcb7c2e1ea8?branch=master


 - License ok
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved. Please fix the aforementioned issue before import.
Comment 3 Tom Hughes 2020-06-24 12:43:58 UTC 
Hmm dropping that require means the Node.js packaging guidelines are going to need fixing to tell people to require nodejs as well as nodejs-packaging...
Comment 4 Gwyn Ciesla 2020-06-24 14:08:46 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-pg-protocol
Note You need to log in before you can comment on or make changes to this bug.