Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 183927 - Review Request: R-wavethresh - R package for wavelets
Summary: Review Request: R-wavethresh - R package for wavelets
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-03-03 20:10 UTC by José Matos
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-03-08 23:32:31 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description José Matos 2006-03-03 20:10:49 UTC
Spec Name or Url: http://www.fc.up.pt/pessoas/jamatos/fedora-extras/R-wavethresh.spec
SRPM Name or Url: http://www.fc.up.pt/pessoas/jamatos/fedora-extras/R-wavethresh-2.2-1.src.rpm
Description: Software to perform 1-d and 2-d wavelet statistics and transforms

Comment 1 Jason Tibbitts 2006-03-07 23:49:42 UTC
This fares a bit better than R-waveslim.  rpmlint says:

W: R-wavethresh invalid-license GPL version 2 or later
W: R-wavethresh no-documentation

Good:
We have no standards for R package naming, but R-packagename is reasonable.
The specfile is clean and understandable.
The source matches upstream.
Package dependencies are sane.
Package builds in mock.

rpmlint finds no documentation, but all supplied documentation is part of R's
internal help system, so this isn't a blocker.

Bad:
rpmlint doesn't like the License: tag.  I have asked on the extras list whether
it is acceptable or not.

Comment 2 José Matos 2006-03-08 09:41:20 UTC
I have modified the package to fill those issues: 
 
%changelog 
* Wed Mar  8 2006 Jose' Matos <jamatos.pt> - 2.2-2 
- Rename License to simply GPL, added DESCRIPTION to %%doc 
 
New package can be found: 
http://www.fc.up.pt/pessoas/jamatos/fedora-extras/R-wavethresh.spec 
http://www.fc.up.pt/pessoas/jamatos/fedora-extras/R-wavethresh-2.2-2.src.rpm 

Comment 3 Jason Tibbitts 2006-03-08 20:28:17 UTC
The license tag is now acceptable and as a bonus we have a bit of documentation.
 rpmlint is placated and everything looks great.

Approved.

Comment 4 José Matos 2006-03-08 23:32:31 UTC
Build on target fedora-development-extras succeeded. 


Note You need to log in before you can comment on or make changes to this bug.