Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 184450 - Review Request: wcstools
Summary: Review Request: wcstools
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Dan Horák
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-03-08 21:37 UTC by Sergio Pascual
Modified: 2008-07-17 00:14 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-06-26 17:53:26 UTC
Type: ---
Embargoed:
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Sergio Pascual 2006-03-08 21:37:15 UTC 
Spec Name or Url: http://t-rex.fis.ucm.es/~spr/wcstools.spec
SRPM Name or Url: http://t-rex.fis.ucm.es/~spr/wcstools-3.6.3-1.fc4.src.rpm
Description: Software utilities to display and manipulate the WCS of a FITS image
Comment 1 Dan Horák 2006-06-14 12:37:34 UTC 
All comment are lost, so I am moving this bug to the previous state.
Comment 2 Sergio Pascual 2006-06-14 13:23:27 UTC 
Great :(

The current version of the packages is here:
http://t-rex.fis.ucm.es/~spr/wcstools.spec
http://t-rex.fis.ucm.es/~spr/wcstools-3.6.3-3.fc5.src.rpm

I have fixed the most important problems with the code and asked upstream about
the license. They say that the binaries should be GPL and the lib LGPL. They are
also working on the warnings that appeared during the compilation
Comment 3 Dan Horák 2006-06-14 15:12:56 UTC 
the URL is http://t-rex.fis.ucm.es/~spr/wcstools-3.6.4-3.fc5.src.rpm :-)

And I think that everything is cleared and so I will prepare formal review.
Comment 4 Sergio Pascual 2006-06-23 09:21:46 UTC 
A new upstream version wcstools has been released. It now includes de license files.

These are the new SRPM and SPEC:
http://t-rex.fis.ucm.es/~spr/wcstools.spec
http://t-rex.fis.ucm.es/~spr/wcstools-3.6.5-1.src.rpm
Comment 5 Dan Horák 2006-06-26 17:10:13 UTC 
Review:
- no defective rpmlint output
- package name OK
- spec file name OK, is in English and is legible
- package meets the Packaging Guidelines
- licenses OK (GPL/LGPL) and are included
- source matches upstream
- compiles and builds at least on i386
- no BuildRequires needed
- no localized files
- has a shared lib and uses ldconfig as scriptlet shell
- creates and owns a directory and does not conflict with existing dirs
- no duplicates files, permissions are set properly, uses %defattr
- has %clean section
- consistent use of macros
- contains code
- no large docs, %doc is not required during runtime
- has devel subpackage, no pkgconfig file
- no .la libtool archives
- not a GUI application

APPROVED
Comment 6 Sergio Pascual 2008-07-16 19:45:37 UTC 
Package Change Request
======================
Package Name: wcstools
New Branches: EL-5
Comment 7 Kevin Fenzi 2008-07-17 00:14:52 UTC 
cvs done.
Note You need to log in before you can comment on or make changes to this bug.