Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1856839 - Review Request: perl-ColorThemeUtil-ANSI - Utility routines related to color themes and ANSI code
Summary: Review Request: perl-ColorThemeUtil-ANSI - Utility routines related to color ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1856854
TreeView+ depends on / blocked
 
Reported: 2020-07-14 14:34 UTC by Jitka Plesnikova
Modified: 2020-07-14 19:46 UTC (History)
2 users (show)

Fixed In Version: perl-ColorThemeUtil-ANSI-0.001-1.fc33
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-14 19:46:58 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+

Attachments (Terms of Use)

Description Jitka Plesnikova 2020-07-14 14:34:13 UTC 
Spec URL: https://jplesnik.fedorapeople.org/perl-ColorThemeUtil-ANSI/perl-ColorThemeUtil-ANSI.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-ColorThemeUtil-ANSI/perl-ColorThemeUtil-ANSI-0.001-1.fc33.src.rpm

Description:
This module provides utility routines related to color themes and ANSI
code.

Fedora Account System Username: jplesnik
Comment 1 Robert-André Mauchin 🐧 2020-07-14 16:09:55 UTC 
URL and Source addresses are Ok.
Source archive (SHA-256: b603f498b6bced96eab11538e5d575b3192ccfb3a20bdf0f83a8dd6c26b353e3) is original. Ok.
Summary verified from lib/ColorThemeUtil/ANSI.pm. Ok.
Description verified. Ok.
License verified from README and lib/ColorThemeUtil/ANSI.pm. Ok.
No XS code, noarch BuildArch is Ok.

Pod::Coverage::TrustPod, Test::Pod::Coverage, Test::Perl::Critic, and Test::Pod are not used. Ok.
AUTHOR_TESTING variable is unset before executing "make test". Ok.

$ rpmlint perl-ColorThemeUtil-ANSI.spec review-perl-ColorThemeUtil-ANSI/results/perl-ColorThemeUtil-ANSI-0.001-1.fc33.noarch.rpm review-perl-ColorThemeUtil-ANSI/results/perl-ColorThemeUtil-ANSI-0.001-1.fc33.src.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpm -q -lv -p review-perl-ColorThemeUtil-ANSI/results/perl-ColorThemeUtil-ANSI-0.001-1.fc33.noarch.rpm 
drwxr-xr-x    2 root     root                        0 Jul 14 17:58 /usr/share/doc/perl-ColorThemeUtil-ANSI
-rw-r--r--    1 root     root                      106 Jun  9 10:11 /usr/share/doc/perl-ColorThemeUtil-ANSI/Changes
-rw-r--r--    1 root     root                     1533 Jun  9 10:11 /usr/share/doc/perl-ColorThemeUtil-ANSI/README
drwxr-xr-x    2 root     root                        0 Jul 14 17:58 /usr/share/licenses/perl-ColorThemeUtil-ANSI
-rw-r--r--    1 root     root                    18367 Jun  9 10:11 /usr/share/licenses/perl-ColorThemeUtil-ANSI/LICENSE
-rw-r--r--    1 root     root                     1897 Jul 14 17:58 /usr/share/man/man3/ColorThemeUtil::ANSI.3pm.gz
drwxr-xr-x    2 root     root                        0 Jul 14 17:58 /usr/share/perl5/vendor_perl/ColorThemeUtil
-rw-r--r--    1 root     root                     2720 Jun  9 10:11 /usr/share/perl5/vendor_perl/ColorThemeUtil/ANSI.pm
File layout ans permissions are Ok.

$ rpm -q --requires -p review-perl-ColorThemeUtil-ANSI/results/perl-ColorThemeUtil-ANSI-0.001-1.fc33.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.32.0)
      1 perl(:VERSION) >= 5.10.1
      1 perl(Color::ANSI::Util) >= 0.161
      1 perl(Exporter) >= 5.57
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.

rpm -q --provides -p review-perl-ColorThemeUtil-ANSI/results/perl-ColorThemeUtil-ANSI-0.001-1.fc33.noarch.rpm | sort -f | uniq -c
      1 perl(ColorThemeUtil::ANSI) = 0.001
      1 perl-ColorThemeUtil-ANSI = 0.001-1.fc33
Binary provides are Ok.

The package builds in Fedora 33 (https://koji.fedoraproject.org/koji/taskinfo?taskID=47206080). Ok.

The package is in line with Fedora and Perl packagaging guidelines.

Resolution: Package approved.
Comment 2 Jitka Plesnikova 2020-07-14 19:13:04 UTC 
https://pagure.io/releng/fedora-scm-requests/issue/27115
Comment 3 Gwyn Ciesla 2020-07-14 19:30:39 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-ColorThemeUtil-ANSI
Note You need to log in before you can comment on or make changes to this bug.