I seem to be missing some dependencies for this package:

DEBUG util.py:621:   Problem 1: conflicting requests
DEBUG util.py:621:    - nothing provides crate(derive_arbitrary/default) = 0.4.5 needed by rust-arbitrary+derive-devel-0.4.5-2.fc33.noarch
DEBUG util.py:621:   Problem 2: nothing provides requested (crate(prost-build/default) >= 0.6.1 with crate(prost-build/default) < 0.7.0)
DEBUG util.py:621:   Problem 3: nothing provides requested (crate(secrecy/default) >= 0.6.0 with crate(secrecy/default) < 0.7.0)
DEBUG util.py:621:   Problem 4: nothing provides requested (crate(secrecy/serde) >= 0.6.0 with crate(secrecy/serde) < 0.7.0)

Looks like the version of rust-secrecy is newer than what this package wants.

Yup, and I also fixed a couple of other issues:
* the s390x of secrecy failed and I missed it: https://koji.fedoraproject.org/koji/taskinfo?taskID=49207122
* there was a issue with the rust-arbitrary build, fixed in rust-arbitrary-0.4.5-3.fc34

SPEC: https://pbrobinson.fedorapeople.org/rust-parsec-interface.spec
SRPM: https://pbrobinson.fedorapeople.org/rust-parsec-interface-0.19.0-2.fc32.src.rpm

There's still one issue, but it's not directly involved with this package so one the below is fixed the above should be fine:

DEBUG util.py:621:  Error: 
DEBUG util.py:621:   Problem: conflicting requests
DEBUG util.py:621:    - nothing provides crate(derive_arbitrary/default) = 0.4.5 needed by rust-arbitrary+derive-devel-0.4.5-3.fc34.noarch

What's the status here?

(In reply to Zbigniew Jędrzejewski-Szmek from comment #5)
> What's the status here?

Literally just added the extra review, see added dep.

The other review is approved. Jared, the ball is in your court now.

Updated:

SPEC: https://pbrobinson.fedorapeople.org/rust-parsec-interface.spec
SRPM: https://pbrobinson.fedorapeople.org/rust-parsec-interface-0.19.0-3.fc32.src.rpm

Got this error trying to build:


error: failed to run custom build command for `parsec-interface v0.20.1 (/builddir/build/BUILD/parsec-interface-0.20.1)`
Caused by:
  process didn't exit successfully: `/builddir/build/BUILD/parsec-interface-0.20.1/target/release/build/parsec-interface-68bf9c316b4e2338/build-script-build` (exit code: 1)
--- stderr
Error: Os { code: 2, kind: NotFound, message: "No such file or directory" }

Ok so for rust-prost-build to do its Protobuffy office, you need to specify where to find the protoc binary:

%build
export PROTOC=%{_bindir}/protoc
%cargo_build



 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

I'll let Jared Smith approve it if it is good for him too.

I forgot:

You need to add a comment explaining what you have change with the fix-metadata patch, and add a link to n upstream PR adding these changes.

SPEC: https://pbrobinson.fedorapeople.org/rust-parsec-interface.spec
SRPM: https://pbrobinson.fedorapeople.org/rust-parsec-interface-0.20.2-1.fc32.src.rpm

> You need to add a comment explaining what you have change with the
> fix-metadata patch, and add a link to n upstream PR adding these changes.

I'm working in parallel to get those fixed, eg the 0.20.2 no longer needs it

Fixed up the protobuf bits

SPEC: https://pbrobinson.fedorapeople.org/rust-parsec-interface.spec
SRPM: https://pbrobinson.fedorapeople.org/rust-parsec-interface-0.20.2-2.fc32.src.rpm

Package is APPROVED.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* Apache License 2.0",
     "Apache License 2.0". 92 files have unknown license. Detailed output
     of licensecheck in /tmp/1862796-rust-parsec-interface/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust-
     parsec-interface-devel , rust-parsec-interface+default-devel , rust-
     parsec-interface+arbitrary-devel , rust-parsec-interface+fuzz-devel ,
     rust-parsec-interface+testing-devel
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: rust-parsec-interface-devel-0.20.2-2.fc34.noarch.rpm
          rust-parsec-interface+default-devel-0.20.2-2.fc34.noarch.rpm
          rust-parsec-interface+arbitrary-devel-0.20.2-2.fc34.noarch.rpm
          rust-parsec-interface+fuzz-devel-0.20.2-2.fc34.noarch.rpm
          rust-parsec-interface+testing-devel-0.20.2-2.fc34.noarch.rpm
          rust-parsec-interface-0.20.2-2.fc34.src.rpm
rust-parsec-interface-devel.noarch: W: invalid-url URL: https://crates.io/crates/parsec-interface HTTP Error 404: Not Found
rust-parsec-interface-devel.noarch: W: hidden-file-or-dir /usr/share/cargo/registry/parsec-interface-0.20.2/.cargo-checksum.json
rust-parsec-interface+default-devel.noarch: W: invalid-url URL: https://crates.io/crates/parsec-interface HTTP Error 404: Not Found
rust-parsec-interface+default-devel.noarch: W: no-documentation
rust-parsec-interface+arbitrary-devel.noarch: W: invalid-url URL: https://crates.io/crates/parsec-interface HTTP Error 404: Not Found
rust-parsec-interface+arbitrary-devel.noarch: W: no-documentation
rust-parsec-interface+fuzz-devel.noarch: W: invalid-url URL: https://crates.io/crates/parsec-interface HTTP Error 404: Not Found
rust-parsec-interface+fuzz-devel.noarch: W: no-documentation
rust-parsec-interface+testing-devel.noarch: W: invalid-url URL: https://crates.io/crates/parsec-interface HTTP Error 404: Not Found
rust-parsec-interface+testing-devel.noarch: W: no-documentation
rust-parsec-interface.src: W: invalid-url URL: https://crates.io/crates/parsec-interface HTTP Error 404: Not Found
6 packages and 0 specfiles checked; 0 errors, 11 warnings.




Rpmlint (installed packages)
----------------------------
rust-parsec-interface+arbitrary-devel.noarch: W: invalid-url URL: https://crates.io/crates/parsec-interface <urlopen error [Errno -3] Temporary failure in name resolution>
rust-parsec-interface+arbitrary-devel.noarch: W: no-documentation
rust-parsec-interface+testing-devel.noarch: W: invalid-url URL: https://crates.io/crates/parsec-interface <urlopen error [Errno -3] Temporary failure in name resolution>
rust-parsec-interface+testing-devel.noarch: W: no-documentation
rust-parsec-interface+default-devel.noarch: W: invalid-url URL: https://crates.io/crates/parsec-interface <urlopen error [Errno -3] Temporary failure in name resolution>
rust-parsec-interface+default-devel.noarch: W: no-documentation
rust-parsec-interface-devel.noarch: W: invalid-url URL: https://crates.io/crates/parsec-interface <urlopen error [Errno -3] Temporary failure in name resolution>
rust-parsec-interface-devel.noarch: W: hidden-file-or-dir /usr/share/cargo/registry/parsec-interface-0.20.2/.cargo-checksum.json
rust-parsec-interface+fuzz-devel.noarch: W: invalid-url URL: https://crates.io/crates/parsec-interface <urlopen error [Errno -3] Temporary failure in name resolution>
rust-parsec-interface+fuzz-devel.noarch: W: no-documentation
5 packages and 0 specfiles checked; 0 errors, 10 warnings.



Source checksums
----------------
https://crates.io/api/v1/crates/parsec-interface/0.20.2/download#/parsec-interface-0.20.2.crate :
  CHECKSUM(SHA256) this package     : 275562850cb6ba82ce17d840cef8279f9649441bc596262e7dd92983e77257b6
  CHECKSUM(SHA256) upstream package : 275562850cb6ba82ce17d840cef8279f9649441bc596262e7dd92983e77257b6


Requires
--------
rust-parsec-interface-devel (rpmlib, GLIBC filtered):
    (crate(bincode/default) >= 1.3.1 with crate(bincode/default) < 2.0.0)
    (crate(derivative/default) >= 2.1.1 with crate(derivative/default) < 3.0.0)
    (crate(log/default) >= 0.4.11 with crate(log/default) < 0.5.0)
    (crate(num-derive/default) >= 0.3.2 with crate(num-derive/default) < 0.4.0)
    (crate(num-traits/default) >= 0.2.12 with crate(num-traits/default) < 0.3.0)
    (crate(num/default) >= 0.3.0 with crate(num/default) < 0.4.0)
    (crate(prost-build/default) >= 0.6.1 with crate(prost-build/default) < 0.7.0)
    (crate(prost/default) >= 0.6.1 with crate(prost/default) < 0.7.0)
    (crate(psa-crypto) >= 0.5.1 with crate(psa-crypto) < 0.6.0)
    (crate(secrecy/default) >= 0.7.0 with crate(secrecy/default) < 0.8.0)
    (crate(secrecy/serde) >= 0.7.0 with crate(secrecy/serde) < 0.8.0)
    (crate(serde/default) >= 1.0.115 with crate(serde/default) < 2.0.0)
    (crate(serde/derive) >= 1.0.115 with crate(serde/derive) < 2.0.0)
    (crate(uuid/default) >= 0.8.1 with crate(uuid/default) < 0.9.0)
    (crate(zeroize/default) >= 1.1.0 with crate(zeroize/default) < 2.0.0)
    (crate(zeroize/zeroize_derive) >= 1.1.0 with crate(zeroize/zeroize_derive) < 2.0.0)
    /usr/bin/bash
    cargo

rust-parsec-interface+default-devel (rpmlib, GLIBC filtered):
    cargo
    crate(parsec-interface)

rust-parsec-interface+arbitrary-devel (rpmlib, GLIBC filtered):
    (crate(arbitrary/default) >= 0.4.6 with crate(arbitrary/default) < 0.5.0)
    (crate(arbitrary/derive) >= 0.4.6 with crate(arbitrary/derive) < 0.5.0)
    cargo
    crate(parsec-interface)

rust-parsec-interface+fuzz-devel (rpmlib, GLIBC filtered):
    (crate(arbitrary/default) >= 0.4.6 with crate(arbitrary/default) < 0.5.0)
    (crate(arbitrary/derive) >= 0.4.6 with crate(arbitrary/derive) < 0.5.0)
    cargo
    crate(parsec-interface)

rust-parsec-interface+testing-devel (rpmlib, GLIBC filtered):
    cargo
    crate(parsec-interface)



Provides
--------
rust-parsec-interface-devel:
    crate(parsec-interface)
    rust-parsec-interface-devel

rust-parsec-interface+default-devel:
    crate(parsec-interface/default)
    rust-parsec-interface+default-devel

rust-parsec-interface+arbitrary-devel:
    crate(parsec-interface/arbitrary)
    rust-parsec-interface+arbitrary-devel

rust-parsec-interface+fuzz-devel:
    crate(parsec-interface/fuzz)
    rust-parsec-interface+fuzz-devel

rust-parsec-interface+testing-devel:
    crate(parsec-interface/testing)
    rust-parsec-interface+testing-devel



Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16
Command line :/usr/bin/fedora-review -b 1862796
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Perl, C/C++, Java, fonts, R, Ocaml, SugarActivity, PHP, Haskell, Python
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-parsec-interface