1867357 – (ansible-collection-google-cloud) Review Request: ansible-collection-google-cloud - Google Cloud Platform collection

Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1867357 (ansible-collection-google-cloud) - Review Request: ansible-collection-google-cloud - Google Cloud Platform collection

Summary: Review Request: ansible-collection-google-cloud - Google Cloud Platform colle...

Keywords:
Status:	CLOSED RAWHIDE
Alias:	ansible-collection-google-cloud
Product:	Fedora
Classification:	Fedora
Component:	Package Review
Sub Component:
Version:	rawhide
Hardware:	Unspecified
OS:	Unspecified
Priority:	unspecified
Severity:	unspecified
Target Milestone:	---
Assignee:	Neal Gompa
QA Contact:	Fedora Extras Quality Assurance
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:	1867360 ansible-collection-community-general
TreeView+	depends on / blocked

Reported:	2020-08-09 07:52 UTC by Igor Raits
Modified:	2020-12-29 21:04 UTC (History)
CC List:	3 users (show)
Fixed In Version:
Doc Type:	If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:	2020-12-29 21:04:23 UTC
Type:	---
Embargoed:
Dependent Products:
Flags:	ngompa13: fedora-review+

Attachments	(Terms of Use)

Description Igor Raits 2020-08-09 07:52:19 UTC

Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-google-cloud.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-google-cloud-0.10.3-1.fc33.src.rpm
Description:
Google Cloud Platform collection.
Fedora Account System Username: ignatenkobrain

Comment 1 Igor Raits 2020-08-09 08:18:54 UTC

New Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-google-cloud.spec
New SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-google-cloud-0.10.3-1.fc33.src.rpm

Comment 2 Andy Mender 2020-08-09 14:27:58 UTC

> # roles/gcloud: Expat
> License:        GPLv2+ and Expat

The code for the Expat license is "MIT", I think: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses

Also, licensecheck picked up the Apache license, too:
google.cloud-0.10.3/tests/integration/targets/gcp_compute_firewall/tasks/update.yml: Apache License 2.0 GENERATED FILE
google.cloud-0.10.3/tests/integration/targets/gcp_kms_crypto_key/tasks/autogen.yml: Apache License 2.0
google.cloud-0.10.3/tests/integration/targets/gcp_kms_key_ring/tasks/autogen.yml: Apache License 2.0

> Source:         https://github.com/ansible-collections/google.cloud/archive/v%{version}/%{name}-%{version}.tar.gz
>Patch0001:      https://github.com/ansible-collections/google.cloud/commit/11e5da0e3af79e8422dd30ddceb837928ccd6bfd.patch#/0001-some-fixes.patch

I would add a comment why the patch is needed.

> %prep
> %autosetup -n google.cloud-%{version} -p1
> rm -vr molecule .github .ansible-lint .yamllint requirements.txt
> find -type f -name '.gitignore' -print -delete

I recommend also something like this to clean up the Python shebangs (respective to the buildroot, of course):
sed -i -e '1{\@^#!.*@d}' plugins/modules/*.py

Full review matrix:
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
     Review: it's a noarch package.
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Expat License", "GPL (v3 or later)",
     "Apache License 2.0". 579 files have unknown license. Detailed output
     of licensecheck in /home/amender/rpmbuild/SPECS/ansible-collection-
     google-cloud/ansible-collection-google-cloud/licensecheck.txt
     Review: see earlier comment.
[!]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
     Review: see earlier comment.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[?]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
     Review: it's a noarch package.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
     Review: see earlier comment.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
     Review: it's a noarch package.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.


Rpmlint
-------
Checking: ansible-collection-google-cloud-0.10.3-1.fc33.noarch.rpm
          ansible-collection-google-cloud-0.10.3-1.fc33.src.rpm
ansible-collection-google-cloud.noarch: W: invalid-license Expat
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_appengine_firewall_rule.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_appengine_firewall_rule_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_bigquery_dataset.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_bigquery_dataset_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_bigquery_table.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_bigquery_table_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_bigtable_instance.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_bigtable_instance_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_cloudbuild_trigger.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_cloudbuild_trigger_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_cloudfunctions_cloud_function.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_cloudfunctions_cloud_function_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_cloudscheduler_job.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_cloudscheduler_job_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_cloudtasks_queue.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_cloudtasks_queue_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_address.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_address_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_autoscaler.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_autoscaler_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_backend_bucket.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_backend_bucket_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_backend_service.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_backend_service_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_disk.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_disk_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_external_vpn_gateway.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_external_vpn_gateway_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_firewall.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_firewall_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_forwarding_rule.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_forwarding_rule_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_global_address.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_global_address_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_global_forwarding_rule.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_global_forwarding_rule_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_health_check.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_health_check_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_http_health_check.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_http_health_check_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_https_health_check.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_https_health_check_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_image.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_image_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_instance.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_instance_group.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_instance_group_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_instance_group_manager.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_instance_group_manager_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_instance_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_instance_template.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_instance_template_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_interconnect_attachment.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_interconnect_attachment_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_network.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_network_endpoint_group.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_network_endpoint_group_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_network_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_node_group.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_node_group_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_node_template.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_node_template_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_region_autoscaler.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_region_autoscaler_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_region_backend_service.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_region_backend_service_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_region_disk.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_region_disk_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_region_health_check.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_region_health_check_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_region_instance_group_manager.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_region_instance_group_manager_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_region_target_http_proxy.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_region_target_http_proxy_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_region_target_https_proxy.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_region_target_https_proxy_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_region_url_map.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_region_url_map_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_reservation.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_reservation_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_resource_policy.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_resource_policy_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_route.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_route_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_router.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_router_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_snapshot.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_snapshot_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_ssl_certificate.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_ssl_certificate_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_ssl_policy.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_ssl_policy_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_subnetwork.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_subnetwork_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_target_http_proxy.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_target_http_proxy_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_target_https_proxy.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_target_https_proxy_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_target_instance.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_target_instance_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_target_pool.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_target_pool_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_target_ssl_proxy.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_target_ssl_proxy_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_target_tcp_proxy.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_target_tcp_proxy_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_target_vpn_gateway.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_target_vpn_gateway_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_url_map.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_url_map_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_vpn_tunnel.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_compute_vpn_tunnel_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_container_cluster.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_container_cluster_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_container_node_pool.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_container_node_pool_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_dns_managed_zone.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_dns_managed_zone_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_dns_resource_record_set.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_dns_resource_record_set_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_filestore_instance.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_filestore_instance_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_iam_role.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_iam_role_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_iam_service_account.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_iam_service_account_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_iam_service_account_key.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_kms_crypto_key.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_kms_crypto_key_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_kms_key_ring.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_kms_key_ring_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_logging_metric.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_logging_metric_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_mlengine_model.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_mlengine_model_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_mlengine_version.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_mlengine_version_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_pubsub_subscription.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_pubsub_subscription_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_pubsub_topic.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_pubsub_topic_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_redis_instance.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_redis_instance_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_resourcemanager_project.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_resourcemanager_project_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_runtimeconfig_config.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_runtimeconfig_config_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_runtimeconfig_variable.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_runtimeconfig_variable_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_serviceusage_service.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_serviceusage_service_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_sourcerepo_repository.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_sourcerepo_repository_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_spanner_database.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_spanner_database_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_spanner_instance.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_spanner_instance_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_sql_database.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_sql_database_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_sql_instance.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_sql_instance_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_sql_ssl_cert.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_sql_user.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_sql_user_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_storage_bucket.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_storage_bucket_access_control.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_storage_default_object_acl.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_storage_object.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_tpu_node.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/google/cloud/plugins/modules/gcp_tpu_node_info.py 644 /usr/bin/python 
ansible-collection-google-cloud.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/google/cloud/roles/stackdriver_logging/molecule/default/.ansible-lint
ansible-collection-google-cloud.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/google/cloud/roles/stackdriver_logging/molecule/default/.yamllint
ansible-collection-google-cloud.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/google/cloud/roles/stackdriver_monitoring/molecule/default/.ansible-lint
ansible-collection-google-cloud.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/google/cloud/roles/stackdriver_monitoring/molecule/default/.yamllint
ansible-collection-google-cloud.src: W: invalid-license Expat
ansible-collection-google-cloud.src: W: unexpanded-macro URL %{ansible_collection_url}
ansible-collection-google-cloud.src: W: invalid-url URL %{ansible_collection_url}
2 packages and 0 specfiles checked; 170 errors, 8 warnings.




Rpmlint (installed packages)
----------------------------
0 packages and 0 specfiles checked; 0 errors, 0 warnings.
(none): E: no installed packages by name ansible-collection-google-cloud



Source checksums
----------------
https://github.com/ansible-collections/google.cloud/archive/v0.10.3/ansible-collection-google-cloud-0.10.3.tar.gz :
  CHECKSUM(SHA256) this package     : afbaf7fd65ca8ff6a49517645fda1cfceee0cba7ff2a238129be9e7ef34e4dc3
  CHECKSUM(SHA256) upstream package : afbaf7fd65ca8ff6a49517645fda1cfceee0cba7ff2a238129be9e7ef34e4dc3


Requires
--------
ansible-collection-google-cloud (rpmlib, GLIBC filtered):
    (ansible >= 2.9.0 with ansible < 2.10.0)
    python3.9dist(google-auth)
    python3.9dist(requests)



Provides
--------
ansible-collection-google-cloud:
    ansible-collection(google.cloud)
    ansible-collection-google-cloud

Comment 3 Igor Raits 2020-08-21 05:23:38 UTC

New Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-google-cloud.spec
New SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-google-cloud-0.10.3-1.fc33.src.rpm

Comment 4 Igor Raits 2020-08-21 05:24:26 UTC

> The code for the Expat license is "MIT", I think: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses

Fixed.

> Also, licensecheck picked up the Apache license, too:

Those are integration tests and I remove them in %install so they are not shipped.

> I would add a comment why the patch is needed.

Done.

> I recommend also something like this to clean up the Python shebangs (respective to the buildroot, of course):

Done.

Comment 5 Andy Mender 2020-08-22 14:06:33 UTC

Looks good, but before I approve, what about these hidden files that rpmlint found? Are they needed by the package?
Rpmlint
-------
Checking: ansible-collection-google-cloud-0.10.3-1.fc34.noarch.rpm
          ansible-collection-google-cloud-0.10.3-1.fc34.src.rpm
ansible-collection-google-cloud.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/google/cloud/roles/stackdriver_logging/molecule/default/.ansible-lint
ansible-collection-google-cloud.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/google/cloud/roles/stackdriver_logging/molecule/default/.yamllint
ansible-collection-google-cloud.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/google/cloud/roles/stackdriver_monitoring/molecule/default/.ansible-lint
ansible-collection-google-cloud.noarch: W: hidden-file-or-dir /usr/share/ansible/collections/ansible_collections/google/cloud/roles/stackdriver_monitoring/molecule/default/.yamllint
ansible-collection-google-cloud.src: W: unexpanded-macro URL %{ansible_collection_url}
ansible-collection-google-cloud.src: W: invalid-url URL %{ansible_collection_url}
2 packages and 0 specfiles checked; 0 errors, 6 warnings.

Comment 6 Andy Mender 2020-10-03 14:52:26 UTC

Hello Igor, any updates on this?

Comment 7 Package Review 2020-11-03 00:45:24 UTC

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.

Comment 8 Igor Raits 2020-12-29 19:39:17 UTC

New Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-google-cloud.spec
New SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-google-cloud-1.0.1-1.fc34.src.rpm

Comment 9 Neal Gompa 2020-12-29 20:17:08 UTC

Taking this review.

Comment 10 Neal Gompa 2020-12-29 20:18:57 UTC

It seems like everything has been addressed from the earlier review.

PACKAGE APPROVED.

Comment 11 Igor Raits 2020-12-29 20:20:51 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/ansible-collection-google-cloud

Note You need to log in before you can comment on or make changes to this bug.