Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1871765 - Container Review Request: thoth-toolbox - This is a toolbox container image for Thoth tools
Summary: Container Review Request: thoth-toolbox - This is a toolbox container image f...
Keywords:
Status: NEW
Alias: None
Product: Fedora Container Images
Classification: Fedora
Component: Container Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Qiyu Yan
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR
TreeView+ depends on / blocked
 
Reported: 2020-08-24 08:38 UTC by Christoph Görn
Modified: 2020-09-08 08:52 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
yanqiyu01: fedora-review?


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github thoth-station thoth-toolbox issues 2 0 None open package python modules installed in toolbox as RPM 2020-12-13 07:25:45 UTC

Description Christoph Görn 2020-08-24 08:38:03 UTC
Container Build Info URL: https://github.com/thoth-station/thoth-toolbox
Description: This is a toolbox container image aggregating some of Thoth tools, including micropipenv and thamos
Fedora Account System Username: goern

Comment 1 Robert-André Mauchin 🐧 2020-08-27 16:10:33 UTC
I don't understand, what are you expecting from this bug in Review Request, if we don't have anything to review?

Comment 2 Qiyu Yan 2020-08-29 10:08:15 UTC
Container review request shouldn't be here. See: https://fedoraproject.org/wiki/Container:Review_Process

Comment 3 Qiyu Yan 2020-08-29 10:48:37 UTC
Changed format, this should make fedpkg happy.

Most thing are just in same structure as what [toolbox] it self do, expect the name part, which I think is of no importance.(which I will confirm later)

[toolbox]: https://src.fedoraproject.org/container/fedora-toolbox/blob/master/f/Dockerfile

Comment 4 Qiyu Yan 2020-08-29 11:09:35 UTC
While I think using pip is not a good idea,since you are using something that haven't packaged into package collection yet, this is not compliance with guideline: https://docs.fedoraproject.org/en-US/containers/guidelines/contents/#_allowed_content

What you need to do then 
- check if those pip packages have already been packaged, if so, use dnf to install instead of pip
- if not so, package them (you can look for help from devel list)
- ping me if those are done :)

Comment 5 Athos Ribeiro 2020-08-29 11:23:35 UTC
- The .osbs-repo-config file is not needed: Fedora's OSBS has no autorebuilds enabled.

- pip content is not allowed, as per the guidelines as Qiyu pointed out.

- The version should be set to 0 according to the guidelines. Alternatively, you should install specific versions of the package so a rebuild won't turn your version into a bogus one.

- You could move the README.md to a help.md file and it should be converted to a man page in the image's root.

Comment 6 Christoph Görn 2020-09-08 08:40:47 UTC
Hey all thanks for the review. I will work on the findings. I think I followed https://docs.fedoraproject.org/en-US/containers/guidelines/contents/#_allowed_content and interpreted "SHOULD NOT container" as... should not, rather than MUST NOT.


Note You need to log in before you can comment on or make changes to this bug.