Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 187235 - Review Request: ices - icecast streaming source client
Summary: Review Request: ices - icecast streaming source client
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Matt Domsch
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-03-29 14:05 UTC by Andreas Thienemann
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-04-24 10:45:06 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Andreas Thienemann 2006-03-29 14:05:36 UTC
Spec Name or Url: http://home.bawue.net/~ixs/ices/ices.spec
SRPM Name or Url: http://home.bawue.net/~ixs/ices/ices-2.0.1-2.src.rpm
Description:
IceS is a source client for a streaming server. The purpose of this client is
to provide an audio stream to a streaming server such that one or more
listeners can access the stream. With this layout, this source client can be
situated remotely from the icecast server.

Comment 1 Andreas Thienemann 2006-03-29 14:11:55 UTC
FYI:
rpmlint returns the following warnings and errors:

W: ices conffile-without-noreplace-flag /etc/logrotate.d/ices
E: ices non-standard-gid /var/log/ices ices
E: ices non-standard-dir-perm /var/log/ices 0770

The warning shouldn't be a problem, and the errors can be ignored. ices is
running under the userid ices and therefore the logdir must belong to another
user. Perms are set accordingly.

Comment 2 Matt Domsch 2006-04-23 18:38:25 UTC
looks quite good (nice cleanup from my attempt last fall!).  A few nits which
can be fixed at CVS checkin time:

Please chkconfig --add only on initial install, not upgrade.
%post
if [ $1 = 1 ]; then
    /sbin/chkconfig --add ices
fi

config(noreplace) the logrotate file:
%config(noreplace) %{_sysconfdir}/logrotate.d/ices



APPROVED.

Comment 3 Andreas Thienemann 2006-04-24 10:45:06 UTC
Thx. Package has been imported into cvs.


Note You need to log in before you can comment on or make changes to this bug.