Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 187923 - Review Request: blktool
Summary: Review Request: blktool
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Tomas Mraz
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-04-04 16:03 UTC by Jeff Garzik
Modified: 2013-07-03 02:28 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-04-05 15:05:45 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Jeff Garzik 2006-04-04 16:03:52 UTC 
Spec Name or Url: http://gtf.org/garzik/blktool/blktool.spec
SRPM Name or Url: http://gtf.org/garzik/blktool/blktool-4-2.src.rpm
Description: Block device settings tool
Comment 1 Jeff Garzik 2006-04-04 16:24:13 UTC 
Similar to "ethtool" package, found in Fedora Core.  By the same author (me) as
ethtool, too.
Comment 2 Tomas Mraz 2006-04-04 19:29:33 UTC 
Review:

rpmlint complains:

E: blktool zero-length /usr/share/doc/blktool-4/ChangeLog

This can be ignored.

The _sbindir macro is redefined, this is OK, however it should be probably later
used instead of the plain /sbin.

There is missing BuildRequires: glib2-devel
Comment 3 Jeff Garzik 2006-04-04 19:49:03 UTC 
Updated to remove empty ChangeLog and add BuildRequires.

_sbindir thing is just aping what evolution has wrought in blktool's sister
package, Fedora Core ethtool.  No idea why, but its important that both of these
packages behave in a similar manner.

New URLs:
http://gtf.org/garzik/blktool/blktool.spec
http://gtf.org/garzik/blktool/blktool-4-3.src.rpm
Comment 4 Tomas Mraz 2006-04-05 08:02:08 UTC 
About the _sbindir - I didn't say that it shouldn't be redefined but that
%{_sbindir} should be used instead of /sbin in the %install and %files sections
probably. But I don't insist on that.

Also probably the INSTALL file should be also removed from %doc because there
are only the generic installation instructions.

However these two above are only nitpicks so I leave it on you if you want to
fix them.

APPROVED
Note You need to log in before you can comment on or make changes to this bug.