Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1880752 - Documents preview doesn't work with Nautilus
Summary: Documents preview doesn't work with Nautilus
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: sushi
Version: 33
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Elad Alfassa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F33FinalBlocker
TreeView+ depends on / blocked
 
Reported: 2020-09-19 16:04 UTC by Alexis Jeandet
Modified: 2020-10-26 14:02 UTC (History)
12 users (show)

Fixed In Version: sushi-3.34.0-4.fc33
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-09-25 17:02:54 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
GNOME Gitlab GNOME/sushi - issues 44 0 None None None 2020-09-20 18:09:38 UTC

Description Alexis Jeandet 2020-09-19 16:04:56 UTC
Description of problem:
Document preview from Nautilus doesn't work on FC33.

Version-Release number of selected component (if applicable):
sushi-3.34.0-3

How reproducible:
Always

Steps to Reproduce:
1. Select from Nautilus any document known to work with sushi (pdf, images, videos,...)
2. Hit space 

Actual results:
Nothing

Expected results:
Document preview as usual

Additional info:
Seen on two machines upgraded from Fedora 32

Comment 1 Fedora Blocker Bugs Application 2020-09-19 16:10:23 UTC
Proposed as a Blocker for 33-beta by Fedora user ajeandet using the blocker tracking app because:

 This bug violates "Default application functionality" requirement since sushi is installed by default and doesn't start as expected.

Comment 2 Chris Murphy 2020-09-19 18:01:36 UTC
I can reproduce the problem with a clean install of 20200917; I'm seeing:
sushi-3.34.0-3.fc33.x86_64
nautilus-3.38.0-1.fc33.x86_64.

Comment 3 Chris Murphy 2020-09-19 18:05:27 UTC
Works as expected with sushi-3.34.0-2.fc32.x86_64 on Fedora Workstation 32, so it is a regression.

Comment 4 Chris Murphy 2020-09-19 18:09:11 UTC
On Fedora 33, when I click to select a screenshot file, and press spacebar - journal records the following.


Sep 19 12:07:12 localhost.localdomain systemd[1706]: Started dbus-:1.2-org.gnome.NautilusPreviewer.
Sep 19 12:07:13 localhost.localdomain org.gnome.Nauti[2546]: Object .Gjs_ImageRenderer (0x5581ece29210), has been already deallocated — impossible to access it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.
Sep 19 12:07:13 localhost.localdomain org.gnome.NautilusPreviewer[2546]: == Stack trace for context 0x5581ecc9f1a0 ==
Sep 19 12:07:13 localhost.localdomain org.gnome.NautilusPreviewer[2546]: #0   5581eccc6dd0 i   resource:///org/gnome/NautilusPreviewer/js/viewers/image.js:138 (2a21b9cdcdd0 @ 41)
Sep 19 12:07:13 localhost.localdomain org.gnome.NautilusPreviewer[2546]: #1   5581eccc6d20 i   resource:///org/gnome/NautilusPreviewer/js/viewers/image.js:166 (2a21b9cdcc90 @ 55)
Sep 19 12:07:13 localhost.localdomain org.gnome.NautilusPreviewer[2546]: #2   5581eccc6c70 i   resource:///org/gnome/NautilusPreviewer/js/viewers/image.js:153 (2a21b9cdcd30 @ 143)
Sep 19 12:07:13 localhost.localdomain org.gnome.NautilusPreviewer[2546]: #3   5581eccc6bd0 i   resource:///org/gnome/NautilusPreviewer/js/ui/main.js:57 (2a21b9cb5740 @ 136)
Sep 19 12:07:13 localhost.localdomain org.gnome.NautilusPreviewer[2546]: #4   5581eccc6b30 i   resource:///org/gnome/gjs/modules/script/package.js:222 (2a21b9c83380 @ 45)
Sep 19 12:07:13 localhost.localdomain org.gnome.NautilusPreviewer[2546]: #5   5581eccc6aa0 i   /usr/libexec/org.gnome.NautilusPreviewer:9 (2a21b9c83100 @ 58)
Sep 19 12:07:13 localhost.localdomain org.gnome.NautilusPreviewer[2546]: == Stack trace for context 0x5581ecc9f1a0 ==
Sep 19 12:07:13 localhost.localdomain org.gnome.NautilusPreviewer[2546]: #0   5581eccc6e60 i   resource:///org/gnome/NautilusPreviewer/js/ui/renderer.js:29 (2a21b9cc5d30 @ 33)
Sep 19 12:07:13 localhost.localdomain org.gnome.NautilusPreviewer[2546]: #1   5581eccc6dd0 i   resource:///org/gnome/NautilusPreviewer/js/viewers/image.js:139 (2a21b9cdcdd0 @ 56)
Sep 19 12:07:13 localhost.localdomain org.gnome.NautilusPreviewer[2546]: #2   5581eccc6d20 i   resource:///org/gnome/NautilusPreviewer/js/viewers/image.js:166 (2a21b9cdcc90 @ 55)
Sep 19 12:07:13 localhost.localdomain org.gnome.NautilusPreviewer[2546]: #3   5581eccc6c70 i   resource:///org/gnome/NautilusPreviewer/js/viewers/image.js:153 (2a21b9cdcd30 @ 143)
Sep 19 12:07:13 localhost.localdomain org.gnome.NautilusPreviewer[2546]: #4   5581eccc6bd0 i   resource:///org/gnome/NautilusPreviewer/js/ui/main.js:57 (2a21b9cb5740 @ 136)
Sep 19 12:07:13 localhost.localdomain org.gnome.NautilusPreviewer[2546]: #5   5581eccc6b30 i   resource:///org/gnome/gjs/modules/script/package.js:222 (2a21b9c83380 @ 45)
Sep 19 12:07:13 localhost.localdomain org.gnome.NautilusPreviewer[2546]: #6   5581eccc6aa0 i   /usr/libexec/org.gnome.NautilusPreviewer:9 (2a21b9c83100 @ 58)
Sep 19 12:07:13 localhost.localdomain org.gnome.Nauti[2546]: gtk_widget_queue_resize: assertion 'GTK_IS_WIDGET (widget)' failed
Sep 19 12:07:13 localhost.localdomain org.gnome.Nauti[2546]: Object .Gjs_ImageRenderer (0x5581ece29210), has been already deallocated — impossible to access it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.
Sep 19 12:07:13 localhost.localdomain org.gnome.Nauti[2546]: g_object_notify: assertion 'G_IS_OBJECT (object)' failed
Sep 19 12:07:34 localhost.localdomain systemd[1]: libvirtd.service: Succeeded.
Sep 19 12:07:34 localhost.localdomain audit[1]: SERVICE_STOP pid=1 uid=0 auid=4294967295 ses=4294967295 subj=system_u:system_r:init_t:s0 msg='unit=libvirtd comm="systemd" exe="/usr/lib/systemd/systemd" hostname=? addr=? terminal=? res=success'

Comment 5 Adam Williamson 2020-09-21 19:38:34 UTC
Discussed at 2020-09-21 blocker review meeting: https://meetbot-raw.fedoraproject.org/fedora-blocker-review/2020-09-21/f33-blocker-review.2020-09-21-16.00.html . We agreed to delay the decision as there's some debate over whether this can be considered "basic" functionality, and we'd like the Workstation WG's input on that.

Comment 6 Lukas Ruzicka 2020-09-22 15:35:30 UTC
According to the Fedora Workstation Working Group, this is NOT a blocking issue.

See their reasoning in https://pagure.io/fedora-workstation/issue/189

Comment 7 Chris Murphy 2020-09-22 16:52:36 UTC
https://pagure.io/fedora-workstation/issue/189#comment-687654

catanzaro commented 2 hours ago
>We discussed this at today's WG meeting.
>sushi is hidden functionality that is probably only used by users who happen to know about it. Humans always make the final decision as to whether an issue is severe enough to >block release regardless of the guiding criteria, so in this case, we suggest not blocking on sushi.
...

Comment 8 Felipe Borges 2020-09-23 11:18:24 UTC
I proposed a *hotfix* at https://src.fedoraproject.org/rpms/sushi/pull-request/2 please, test!

Comment 9 Alexis Jeandet 2020-09-23 12:09:59 UTC
(In reply to Felipe Borges from comment #8)
> I proposed a *hotfix* at
> https://src.fedoraproject.org/rpms/sushi/pull-request/2 please, test!

Hi, thank you for the fix. It seems to work with basic files like PDF and png files but not with odg files which used to work in the past. Maybe the odg issue is not related.

Comment 10 Fedora Update System 2020-09-23 12:22:31 UTC
FEDORA-2020-4cfd52878a has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-4cfd52878a

Comment 11 Kalev Lember 2020-09-23 12:26:49 UTC
Proposing as a Beta Freeze exception as we have a fix now (Thanks Felipe!)

Comment 12 Chris Murphy 2020-09-23 15:14:20 UTC
Updated to sushi-3.34.0-4.fc33 and the problem no longer occurs; I see previews.

Comment 13 Fedora Update System 2020-09-23 15:27:09 UTC
FEDORA-2020-4cfd52878a has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-4cfd52878a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-4cfd52878a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Felipe Borges 2020-09-23 15:57:44 UTC
(In reply to Alexis Jeandet from comment #9)
> (In reply to Felipe Borges from comment #8)
> > I proposed a *hotfix* at
> > https://src.fedoraproject.org/rpms/sushi/pull-request/2 please, test!
> 
> Hi, thank you for the fix. It seems to work with basic files like PDF and
> png files but not with odg files which used to work in the past. Maybe the
> odg issue is not related.

I am going to investigate that. Thanks for letting me know!

Comment 15 Alexis Jeandet 2020-09-23 16:10:33 UTC
- It also work with videos but with this bug still present https://gitlab.gnome.org/GNOME/sushi/-/issues/30.
- Works with doc, docx, xlsx, html.
- It doesn't work with MP3.
I also have a funny behavior, if I hit space on a mp3 or odg file it does nothing but as soon as I select a file like a picture it shows preview. As if preview was queued and processed on the first compatible file.

Comment 16 Fedora Update System 2020-09-25 17:02:54 UTC
FEDORA-2020-4cfd52878a has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 17 Lukas Ruzicka 2020-10-26 14:02:51 UTC
Bug fixed, CommonBugs not needed.


Note You need to log in before you can comment on or make changes to this bug.