Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1881585 - Review Request: golang-github-projectdiscovery-fdmax - Helper Library to increase automatically the file descriptors
Summary: Review Request: golang-github-projectdiscovery-fdmax - Helper Library to incr...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1881363 1881611
TreeView+ depends on / blocked
 
Reported: 2020-09-22 17:53 UTC by Fabian Affolter
Modified: 2020-12-04 09:23 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-12-04 09:23:16 UTC
Type: Bug
Embargoed:
zebob.m: fedora-review+

Attachments (Terms of Use)

Description Fabian Affolter 2020-09-22 17:53:50 UTC 
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-projectdiscovery-fdmax.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-projectdiscovery-fdmax-0.0.2-1.fc32.src.rpm

Project URL: https://github.com/projectdiscovery/fdmax

Description:
Small Helper Library to increase automatically the file descriptors limits for
the current process.

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=52034303

rpmlint output:
$ rpmlint golang-github-projectdiscovery-fdmax-0.0.2-1.fc32.src.rpm 
golang-github-projectdiscovery-fdmax.src: W: invalid-license # FIXME
golang-github-projectdiscovery-fdmax.src: W: no-%build-section
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

$ rpmlint golang-github-projectdiscovery-fdmax-devel-0.0.2-1.fc32.noarch.rpm 
golang-github-projectdiscovery-fdmax-devel.noarch: W: invalid-license # FIXME
golang-github-projectdiscovery-fdmax-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/projectdiscovery/fdmax/.goipath
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Fedora Account System Username: fab


The lib has no license at the moment: https://github.com/projectdiscovery/fdmax/issues/3
Comment 1 Fabian Affolter 2020-09-22 18:05:36 UTC 
License was added. It's MIT but no new release published yet.
Comment 2 Robert-André Mauchin 🐧 2020-11-04 10:40:42 UTC 
 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved. Don't forget to fix the license field before import.
Comment 3 Fabian Affolter 2020-11-08 14:26:05 UTC 
Thanks for the review.
Comment 4 Gwyn Ciesla 2020-11-09 16:19:41 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-projectdiscovery-fdmax
Note You need to log in before you can comment on or make changes to this bug.