Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1886406 - Gnome software unable to rate review [NEEDINFO]
Summary: Gnome software unable to rate review
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-software
Version: 33
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Richard Hughes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: AcceptedFreezeException RejectedBlocker
Depends On:
Blocks: F33FinalFreezeException
TreeView+ depends on / blocked
 
Reported: 2020-10-08 12:02 UTC by Lukas Ruzicka
Modified: 2022-06-30 19:56 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug
Embargoed:
awilliam: needinfo? (lruzicka)

Attachments (Terms of Use)
Error message (115.63 KB, image/png)
2020-10-08 12:02 UTC, Lukas Ruzicka 		no flags Details
View All

Description Lukas Ruzicka 2020-10-08 12:02:16 UTC 
Created attachment 1719930 [details]
Error message

Description of problem:

With gnome-software from the Gnome megaupdate 3.38.1, it is possible to add the review of the application, but it is NOT possible to rate it (useful, not useful).

Any attemtp ends up with an error, see screenshot. Similar line appears in journalctl.

Version-Release number of selected component (if applicable):

Gnome 3.38.1

How reproducible:

Always

Steps to Reproduce:
1. Start Gnome-software
2. Go to application page
3. Thumb through the reviews.
4. Click on YES or NO.

Actual results:

Cannot rate, ends up in error.

Expected results:

Rating should be possible.
Comment 1 Fedora Blocker Bugs Application 2020-10-08 12:24:31 UTC 
Proposed as a Blocker for 33-final by Fedora user lruzicka using the blocker tracking app because:

 I am proposing this as a blocker to discuss if the basic functionality criterion is met or not.

https://fedoraproject.org/wiki/Fedora_33_Final_Release_Criteria#Default_application_functionality
Comment 2 Adam Williamson 2020-10-08 18:10:43 UTC 
+3 FE in the ticket, accepting. We have -3 blocker so far, but leaving that open a bit longer in case anyone disagrees.
Comment 3 Adam Williamson 2020-10-09 22:57:46 UTC 
We have -4 blocker votes now, so rejecting.
Comment 4 Adam Williamson 2020-10-15 16:44:09 UTC 
Lukas: when you say "similar lines appear in journalctl", what lines exactly? Do they match this upstream report: https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1010 ?
Comment 5 Adam Williamson 2020-10-15 18:21:36 UTC 
From #fedora-desktop, AsciiWolf reported he can reproduce a similar issue and gets the same journal lines as in #1010. He found that the problem seems related to flatpaks, i.e. things from source registry.fedoraproject.org:

<AsciiWolf> looks like that rating any comment under any app from a Fedora Flatpak source always fails, at least on my vm system

Lukas, can you see if you find the same thing?
Comment 6 Adam Williamson 2020-10-15 19:04:54 UTC 
So I played around with this a bit in the live environment in a VM, trying leaving reviews on various apps (mainly Maps, but also Notes and Thunderbird). I reproduced the bug a couple of times, but couldn't find anything obviously deterministic about how. It *does* feel like it has something to do with apps available as both flatpaks and RPMs, though, like something is getting confused about which it's dealing with. I also frequently found problems trying to *remove* reviews, which often fails with this error:

ODRS server returned status 400: {
    "msg": "no review",
    "success": false
}

or this one:

ODRS server returned status 400: {
    "msg": "invalid data, required review_id",
    "success": false
}

which again seemed to feel like it was maybe happening on apps available as both flatpak and RPM, and something was getting confused about which it was trying to deal with. Sometimes in the UI I'd see a review I'd left on the flatpak when I was looking at the RPM view, and vice versa...

perhaps the cache doesn't properly distinguish between the flatpak and RPM sourced cases, and that's the source of all the trouble?
Comment 7 Fedora Admin user for bugzilla script actions 2021-04-29 12:08:18 UTC 
This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.
Comment 8 Fedora Admin user for bugzilla script actions 2022-06-30 19:56:08 UTC 
This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.
Note You need to log in before you can comment on or make changes to this bug.