Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 189009 - Review Request: bzrtools - A collection of utilities and plugins for Bazaar-NG
Summary: Review Request: bzrtools - A collection of utilities and plugins for Bazaar-NG
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Orion Poplawski
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-04-14 17:18 UTC by Shahms E. King
Modified: 2014-09-15 12:00 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-05-24 14:37:09 UTC
Type: ---
Embargoed:
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Shahms E. King 2006-04-14 17:18:18 UTC 
Spec URL: http://shahms.mesd.k12.or.us/packages/bzrtools.spec
SRPM URL: http://shahms.mesd.k12.or.us/packages/bzrtools-0.7-1.src.rpm
Description:
BzrTools is a collection of plugins for Bazaar-NG (bzr).  Among the included
plugins are:
* push - uses rsync to push local changes to a remote server
* annotate - prints a file annotated with the revision next to each line
* baz-import - (Requres PyBaz) import an arch archive losslessly into bzr
* shelve/unshelve - allows you to undo some changes, commit, and restore
* clean-tree - remove unknown, ignored-junk, or unversioned files from the tree
* graph-ancestry - use dot to produce banch ancestry graphs
* shell - a bzr command interpreter with command completion
* patch - apply a patch to your tree from a file or URL
Comment 1 Orion Poplawski 2006-05-12 22:08:43 UTC 
Looks like you want to update to 0.8.1, but:

- spec file is clean and legible.
- md5sum matches
- rpmlint:
E: bzrtools non-executable-script
/usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/hunk_selector.py 0644
E: bzrtools non-executable-script
/usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/__init__.py 0644
E: bzrtools non-executable-script
/usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/diffstat.py 0644
E: bzrtools non-executable-script
/usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/shelf_tests.py 0644
E: bzrtools non-executable-script
/usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/shelf.py 0644
E: bzrtools non-executable-script
/usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/test.py 0644

though since they are library routines, it isn't necessary to be executable.
- license matches source.
- owns all files and directories.

MUST FIX:

- add COPYING to %doc.
Comment 2 Shahms E. King 2006-05-12 22:31:18 UTC 
Thanks for taking the time to review the package. I added COPYING, updated to
0.8.1 and fixed a minor problem with bzrtools requiring the same version of bzr
rather than the actually required version of 0.8

The new files are at:
http://shahms.mesd.k12.or.us/packages/bzrtools.spec
http://shahms.mesd.k12.or.us/packages/bzrtools-0.8.1-1.src.rpm
Comment 3 Orion Poplawski 2006-05-12 22:41:17 UTC 
(In reply to comment #1)
> - rpmlint:
> E: bzrtools non-executable-script
> /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/hunk_selector.py 0644
> E: bzrtools non-executable-script
> /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/__init__.py 0644
> E: bzrtools non-executable-script
> /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/diffstat.py 0644
> E: bzrtools non-executable-script
> /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/shelf_tests.py 0644
> E: bzrtools non-executable-script
> /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/shelf.py 0644
> E: bzrtools non-executable-script
> /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/test.py 0644

Oops, these need to get fixed.  Those scripts that can be run directly need to
be executable.  Those that are library modules need to have #!/usr/bin/python
stripped from them.

More on Monday...
Comment 4 Shahms E. King 2006-05-15 15:40:33 UTC 
Fixed, new files at:
http://shahms.mesd.k12.or.us/packages/bzrtools.spec
http://shahms.mesd.k12.or.us/packages/bzrtools-0.8.1-2.src.rpm
Comment 5 Orion Poplawski 2006-05-15 16:35:41 UTC 
- Package builds in mock
- rpmlint clean now

Fix:

- BR should be python, not python-devel.

With that fix, this is approved.
Comment 6 Shahms E. King 2006-05-16 16:45:12 UTC 
packages with BR: python are at:
http://shahms.mesd.k12.or.us/packages/bzrtools.spec
http://shahms.mesd.k12.or.us/packages/bzrtools-0.8.1-3.src.rpm
Comment 7 Orion Poplawski 2006-05-17 15:42:07 UTC 
APPROVED.
Comment 8 Steve Traylen 2014-09-12 06:43:28 UTC 
Package Change Request
======================
Package Name: bzrtools
New Branches: epel7
Owners: bar stevetraylen
Comment 9 Gwyn Ciesla 2014-09-15 12:00:07 UTC 
Git done (by process-git-requests).

Dropped bar from the owners list.
Note You need to log in before you can comment on or make changes to this bug.