Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 189013 - Review Request: python-sqlalchemy - Modular and flexible ORM library for python
Summary: Review Request: python-sqlalchemy - Modular and flexible ORM library for python
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: John Mahowald
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-04-14 17:36 UTC by Shahms E. King
Modified: 2011-07-12 12:38 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-05-24 14:42:55 UTC
Type: ---
Embargoed:
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Shahms E. King 2006-04-14 17:36:36 UTC 
Spec URL: http://shahms.mesd.k12.or.us/packages/python-sqlalchemy.spec
SRPM URL: http://shahms.mesd.k12.or.us/packages/python-sqlalchemy-0.1.6-1.src.rpm
Description: 
SQLAlchemy is an Object Relational Mappper (ORM) that provides a flexible,
high-level interface to SQL databases.  Database and domain concepts are
decoupled, allowing both sides maximum flexibility and power. SQLAlchemy
provides a powerful mapping layer that can work as automatically or as manually
as you choose, determining relationships based on foreign keys or letting you
define the join conditions explicitly, to bridge the gap between database and
domain.
Comment 1 John Mahowald 2006-05-16 15:14:56 UTC 
- rpmlint checks return:

W: python-sqlalchemy wrong-file-end-of-line-encoding
/usr/share/doc/python-sqlalchemy-0.1.6/doc/build/content/tutorial.txt
E: python-sqlalchemy wrong-script-end-of-line-encoding
/usr/share/doc/python-sqlalchemy-0.1.6/doc/build/runhtml.py
W: python-sqlalchemy wrong-file-end-of-line-encoding
/usr/share/doc/python-sqlalchemy-0.1.6/doc/build/testdocs.py
W: python-sqlalchemy wrong-file-end-of-line-encoding
/usr/share/doc/python-sqlalchemy-0.1.6/doc/build/txt2myt.py

Easily fixed with sed or perl.

W: python-sqlalchemy doc-file-dependency
/usr/share/doc/python-sqlalchemy-0.1.6/doc/build/runhtml.py /usr/bin/env

python will be installed, so this should be fine.

- package meets naming guidelines
- package meets packaging guidelines
- license (MIT) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream

Change source URL to download.sourceforge.net however, to automate downloads.

- package compiles on FC5 (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- no need for .desktop file 

doc web server script thing doesn't work. 
$ ./runhtml.py
: No such file or directory

This is end of line problem as mentioned previously. Also, these scripts seem to
 convert and write html files, which fails due to permissions. You could
generate this html in your %install phase, elminating the need for these scripts.
Comment 2 Shahms E. King 2006-05-16 17:44:29 UTC 
Thanks for looking at the packages. Considering all of the rpmlint problems were
related to the scripts for building the documentation (which is already built in
the source tar ball), they are removed and not installed with the actual
documentation. I also updated to the newest upstream version (0.1.7).
http://shahms.mesd.k12.or.us/packages/python-sqlalchemy.spec
http://shahms.mesd.k12.or.us/pacakges/python-sqlalchemy-0.1.7-1.src.rpm
Comment 3 John Mahowald 2006-05-18 00:57:57 UTC 
rpmlint and I are happy now.

APPROVED
Comment 4 Toshio Kuratomi 2007-07-24 18:25:23 UTC 
Package Change Request
======================
Package Name: python-sqlalchemy
New Branches: EL-5
Updated Fedora Owners:
shahms,toshio,ivazqueznet
Updated Fedora CC: 
Updated EPEL Owners: shahms,toshio,ivazqueznet

Officially adding comaintainers and branching for EPEL-5
Comment 5 Ignacio Vazquez-Abrams 2007-07-30 17:22:10 UTC 
Package Change Request
======================
Package Name: python-sqlalchemy
Updated EPEL Owners: shahms,toshio
Comment 6 Jason Tibbitts 2007-07-30 17:47:51 UTC 
CVS done.
Comment 7 Rahul Sundaram 2011-07-12 09:53:31 UTC 
Package Change Request
======================
Package Name: python-sqlalchemy
New Branches: el6
Owners: sundaram pjp
InitialCC:
Comment 8 Gwyn Ciesla 2011-07-12 12:38:21 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.