Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 189040 - Review Request: perl-Object-Accessor
Summary: Review Request: perl-Object-Accessor
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
Depends On:
Blocks: FE-ACCEPT 189048
TreeView+ depends on / blocked
Reported: 2006-04-14 23:45 UTC by Steven Pritchard
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2006-04-21 22:01:12 UTC
Type: ---

Attachments (Terms of Use)

Description Steven Pritchard 2006-04-14 23:45:39 UTC
Spec URL:
Object::Accessor provides an interface to create per object accessors (as
opposed to per Class accessors, as, for example, Class::Accessor provides).

Comment 1 Jason Tibbitts 2006-04-15 03:50:57 UTC
Requires: perl(Params::Check) >= 0.23 is redundant; RPM finds the requirement on
its own, leading to a duplicate in the requires list.  I believe we all decided
that this was a blocker.

* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written, uses macros consistently and
conforms to the Perl template.
* license field matches the actual license.
* license is open source-compatible.  It's not included separately in the
package, but this is not necessary as the upstream tarball does not include it.
* source files match upstream:
   722421fcbe2a18facd056ea6edb1be4f  Object-Accessor-0.12.tar.gz
   722421fcbe2a18facd056ea6edb1be4f  Object-Accessor-0.12.tar.gz-srpm
* BuildRequires are proper.
* package builds in mock.
* rpmlint is silent.
X final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directory it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

Comment 2 Steven Pritchard 2006-04-15 22:59:52 UTC
RPM doesn't pick up the versioned dep.  While I'd prefer to keep the explicit
versioned dep, here it is without:

Comment 3 Jason Tibbitts 2006-04-16 05:01:36 UTC
For some reason I recall that it was decided that we shouldn't allow the
duplicate requires, but now I can't find a reference.  I seem to remember that
you were in on the discussion, but if you don't remember then my mind must be
playing tricks on me.  I personally don't have any problem with it since RPM
won't determine versioned perl dependencies on its own, so I'll go ahead and
approve this.  I do think it's worth clarifying.

APPROVED.  Just check in the version you prefer.

Comment 4 Steven Pritchard 2006-04-21 22:01:12 UTC
Imported (-2), branches created, and builds requested.


Note You need to log in before you can comment on or make changes to this bug.