Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 189150 - Review Request: mod_mono
Summary: Review Request: mod_mono
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Package Reviews List
: 189149 (view as bug list)
Depends On: 189151
TreeView+ depends on / blocked
Reported: 2006-04-17 16:52 UTC by Paul F. Johnson
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2006-09-10 09:50:04 UTC
Type: ---

Attachments (Terms of Use)
Mock Build Failure log (deleted)
2006-05-10 14:01 UTC, Brian Pepple
no flags Details

Description Paul F. Johnson 2006-04-17 16:52:24 UTC
Spec URL:

mod_mono is an Apache module which allows Apache to serve up ASP.NET pages

Comment 1 Paul F. Johnson 2006-04-17 17:05:45 UTC
*** Bug 189149 has been marked as a duplicate of this bug. ***

Comment 2 Paul F. Johnson 2006-04-18 22:18:42 UTC
Spec URL:

libdir now set to /usr/lib irrespective of what it's built on
spec file mods

Comment 3 Michael J Knox 2006-04-24 03:08:32 UTC
Builds on FC5, rpmlint complains a little:

W: mod_mono conffile-without-noreplace-flag /etc/httpd/conf/mod_mono.conf
W: mod_mono one-line-command-in-%post /sbin/ldconfig
W: mod_mono one-line-command-in-%postun /sbin/ldconfig

Also, the config file should be in /etc/httpd/conf.d/ ? 

Comment 4 Paul F. Johnson 2006-04-24 06:28:54 UTC
The conf file should be in conf.d - good catch, thanks. The others are warnings
- not too concerned over them.

Comment 5 Paul F. Johnson 2006-05-08 23:21:00 UTC
Checked the for where the software thinks the config file should be
and it's picked up by what apxs returns for an environment variable (in this
case, /usr/httpd/conf)

I'm not sure, but shouldn't apxs return that config files should be in conf.d?
If this is the case, can someone confirm it so that I can file a BZ against apsx?

Comment 6 Brian Pepple 2006-05-10 14:01:31 UTC
Created attachment 128850 [details]
Mock Build Failure log

Here's a couple of items:

1. URL is incorrect.  Should be ''.
2. Need full Source0.
3. License is Apache, not GPL
4. Fails to build in Mock (devel).  I've attach the build log for you.	The
problem appears to be the test for apache in the file.  It's not
getting the version of apache correctly and assuming it's 1.3 , instead of 2.2.

Comment 7 Paul F. Johnson 2006-06-04 13:37:00 UTC
Spec URL:

Change of URL
A couple of tweaks. I'll address #6 today

Comment 8 Paul F. Johnson 2006-08-10 12:44:52 UTC
Not much has changed, though I'm expecting an updated release from the Mono
people soon

Comment 9 Paul F. Johnson 2006-08-31 00:25:45 UTC
Spec URL:


Compiles cleanly, rpmlint is more or less happy.
The package is already architecture agnostic, though I had to mess in the spec
so that the config when to http/conf.d instead of httpd/conf

Plenty of fixes to the spec file as well

Comment 10 Kevin Fenzi 2006-09-08 03:06:54 UTC
OK - Package name
OK - Spec file matches base package name.
OK - Meets Packaging Guidelines.
See below - License
See below - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
3f0408a350f6f55029b75f4332be171f  mod_mono-1.1.17.tar.gz
3f0408a350f6f55029b75f4332be171f  mod_mono-1.1.17.tar.gz.1
OK - Package compiles and builds on at least one arch.
OK - BuildRequires correct
OK - Spec handles locales/find_lang
OK - Spec has needed ldconfig in post and postun
OK - Package owns all the directories it creates.
OK - Package has no duplicate files in %files.
See below - Package has %defattr and permissions on files is good.
See below - Package has a correct %clean section.
OK - Spec has consistant macro usage.
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - .la files are removed.  
OK - Package doesn't own any directories other packages own.
OK - No rpmlint output.


See below - Should include License or ask upstream to include it.
OK - Should build in mock.


1. URL and Source0 are not correct.
URL should be the link to the website of the package.
Suggest something like:
Source0 should be the full link to the source file.
Suggest something like:

2. The License looks wrong. The code and the COPYING file are
the Apache License, Version 2.0. NOT the GPL.

Note that these items are duplicated from comment #6.
Can you fix them? Or indicate why not?

3. Might include the INSTALL doc? In many cases this is a generic
document from the auto tools, but in this case it has some useful
apache configuration information, IMHO.

4. Might change the defattr from:
%defattr(-, root, root)
%defattr(-, root, root,-)

5. You seem to be missing a %clean section. Please add one.

6. You should perhaps Require: httpd >= 2.2 ?   
Otherwise this package is pretty useless without apache?

Comment 11 Kevin Fenzi 2006-09-08 03:17:36 UTC
Oh, I ran rpmlint on the wrong build. It reports: 

W: mod_mono conffile-without-noreplace-flag /etc/httpd/conf.d/mod_mono.conf

Should set that to be %config(noreplace) ?

E: mod_mono no-cleaning-of-buildroot
E: mod_mono no-%clean-section

That would get fixed by adding a %clean section...

W: mod_mono mixed-use-of-spaces-and-tabs

Would be good to clean out and only use spaces or tabs... 

Comment 12 Paul F. Johnson 2006-09-08 20:52:50 UTC
Fixed all the bits. The source is actually permitted as it stands (I queried
this over another package a while back and it was fine)

rpmlint is now clean
mock is happy (i386)

Comment 13 Kevin Fenzi 2006-09-09 03:59:02 UTC
In reply to comment #12:

Great. Can you upload the fixed version to look at? :) 

Is there any reason not to include the full URL in Source0? 
It does make it easier for someone to download the source without having 
to hunt around on the site for a download link... 

Comment 14 Paul F. Johnson 2006-09-09 11:10:23 UTC
Spec URL:

Spec file altered as the SOURCE and URL were wrong (URL was actually the SOURCE!)

Comment 15 Kevin Fenzi 2006-09-10 00:29:26 UTC
All the inital items seem to be fixed up... 
you do now seem to have two Source0 lines: 


The first one of those should be the URL: tag. 

Provided you fix that up, I'm happy to APPROVE this package. 
Don't forget to close this bug NEXTRELEASE once it's been imported and built. 

Comment 16 Paul F. Johnson 2006-09-10 09:50:04 UTC
Thanks - fixed and imported :-)

Note You need to log in before you can comment on or make changes to this bug.