Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 1903656 - Review Request: perl-File-DirList - Provide a sorted list of directory content
Summary: Review Request: perl-File-DirList - Provide a sorted list of directory content
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Jerry James
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 1903378
TreeView+ depends on / blocked
Reported: 2020-12-02 15:14 UTC by Sandro Mani
Modified: 2020-12-04 14:55 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2020-12-04 14:55:42 UTC
Type: ---
loganjerry: fedora-review+

Attachments (Terms of Use)

Description Sandro Mani 2020-12-02 15:14:46 UTC
Spec URL:
Description: Provide a sorted list of directory content
Fedora Account System Username: smani

Scratch build:

Comment 1 Jerry James 2020-12-02 16:23:03 UTC
I will take this review.  I don't have anything that needs reviewing right now.

Comment 2 Jerry James 2020-12-02 16:37:48 UTC
Please note that README has the wrong end-of-line encodings.  Fix that before you check in.  This package is APPROVED.

Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[-]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
[-]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /usr/share/perl5/vendor_perl/File(perl-File-chmod, perl-File-
     CheckTree, perl-File-Modified, perl-File-Find-Rule-PPI, perl-File-
     LoadLines, perl-File-ConfigDir, perl-File-Flock, perl-File-Copy-
     Recursive-Reduced, perl-File-Read, perl-File-Type, perl-File-chdir,
     perl-File-Slurp, perl-File-Which, perl-File-Edit-Portable, perl-File-
     ShareDir-ProjectDistDir, perl-File-KeePass, perl-File-Find-Object-
     Rule, perl-File-Share, perl-File-NCopy, perl-File-Comments, perl-File-
     Fetch, perl-File-Inplace, perl-File-Path, perl-File-Slurper, perl-
     File-Find-utf8, perl-File-Find-Rule-VCS, perl-File-Type-WebImages,
     perl-File-Remove, perl-File-pushd, perl-File-Find-Rule, perl-File-
     UserDirs, perl-File-Find-Rule-Perl, perl-File-Spec-Native, perl-File-
     Next, perl-File-Temp, perl-File-Listing, perl-File-Pid, perl-File-
     Path-Tiny, perl-File-ShareDir-Install, perl-File-Find-Iterator, perl-
     File-Find-Rule-Age, perl-File-Tail, perl-File-Zglob, perl-File-Flat,
     perl-File-ChangeNotify, perl-File-NFSLock, perl-File-HomeDir, perl-
     File-MMagic, perl-File-FindLib, perl-File-Rsync, perl-File-SearchPath,
     perl-File-Find-Object, perl-File-DirCompare, perl-File-PathList, perl-
     File-Finder, perl-File-BOM, perl-File-BaseDir, perl-File-DesktopEntry,
     perl-File-ShareDir, perl-File-Slurp-Tiny, perl-File-Tempdir, perl-
     File-MimeInfo, perl-File-Copy-Recursive, perl-File-Tee, perl-File-
     Touch, perl-Image-ExifTool, perl-File-ReadBackwards)

     This is not an error.  The perl packaging guidelines require this.

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

[x]: Package contains the mandatory BuildRequires and Requires:.
[x]: CPAN urls should be non-versioned.

===== SHOULD items =====

[!]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Checking: perl-File-DirList-0.05-1.fc34.noarch.rpm
perl-File-DirList.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-File-DirList/README
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

Rpmlint (installed packages)
perl-File-DirList.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-File-DirList/README
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Source checksums
---------------- :
  CHECKSUM(SHA256) this package     : 993b7d7662e55798448a1edaccb9abd281d2bd23be7eab99f569b8e2962d3bc3
  CHECKSUM(SHA256) upstream package : 993b7d7662e55798448a1edaccb9abd281d2bd23be7eab99f569b8e2962d3bc3

perl-File-DirList (rpmlib, GLIBC filtered):


Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 1903656 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic, Perl
Disabled plugins: PHP, Python, fonts, C/C++, R, SugarActivity, Ocaml, Haskell, Java, Ruby

Comment 3 Sandro Mani 2020-12-02 16:39:46 UTC
Thanks a lot!

Comment 4 Gwyn Ciesla 2020-12-02 17:19:35 UTC
(fedscm-admin):  The Pagure repository was created at

Comment 5 Petr Šabata 2020-12-02 17:30:25 UTC
You should also add perl(Exporter) and sed to your BRs.

Comment 6 Sandro Mani 2020-12-02 17:32:22 UTC
Thanks, done!

Note You need to log in before you can comment on or make changes to this bug.