Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 191111 - Review Request: perl-Test-Cmd - Perl module for portable testing of commands and scripts
Summary: Review Request: perl-Test-Cmd - Perl module for portable testing of commands ...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Chris Weyl
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-05-08 22:42 UTC by Jose Pedro Oliveira
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-05-11 16:52:19 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Jose Pedro Oliveira 2006-05-08 22:42:46 UTC 
Spec URL:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-Test-Cmd.spec

SRPM URL:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-Test-Cmd-1.05-1.src.rpm

Description:
The Test::Cmd module provides a framework for portable automated testing
of executable commands and scripts (in any language, not just Perl),
especially commands and scripts that interace with the file system.
Comment 1 Chris Weyl 2006-05-10 15:36:54 UTC 
MUSTS:

- rpmlint checks return nothing (good)
- package meets naming guidelines
- package meets packaging guidelines
- license (Perl: GPL or Artistic) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

Looks good by me.  APPROVED
Comment 2 Jose Pedro Oliveira 2006-05-11 16:52:19 UTC 
Thanks for the review.

Imported and build for FC-4, FC-5, and devel.
Note You need to log in before you can comment on or make changes to this bug.