Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 1912419 - Review Request: python-asyncwhois - Python module for performing WHOIS queries
Summary: Review Request: python-asyncwhois - Python module for performing WHOIS queries
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2021-01-04 12:15 UTC by Fabian Affolter
Modified: 2021-07-01 00:45 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2021-07-01 00:45:34 UTC
Type: Bug

Attachments (Terms of Use)

Description Fabian Affolter 2021-01-04 12:15:50 UTC
Spec URL:

Project URL:

Python module for performing WHOIS queries for any domain.

Koji scratch build:

rpmlint output:
$ rpmlint python-asyncwhois-0.2.0-1.fc33.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint python3-asyncwhois-0.2.0-1.fc33.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Fedora Account System Username: fab

Comment 1 Ben Beasley 2021-01-15 16:58:41 UTC
Before a full review, would you mind taking care of these?

- The %python_provide macro is obsolete, and you do not even need %py_provides if you are not packaging for Fedora 32. (Somebody really needs to update pyp2rpm to match the current guidelines; the same things keep coming up over and over.)
- A new version 0.2.2 is available.
- You can use the GitHub tarball and run the tests, because your issue is now fixed. You’ll need to add the install_requires as BR’s.
- Upstream added the separate license file in, too.

This is not mandatory, but please consider whether you might want to use the pyproject-rpm-macros ( Generated BR’s are really nice; you get the version requirements from upstream if applicable, and you’ll never forget to update them. In, I provided an example of rewriting a simple spec file to use the pyproject-rpm-macros. In this case, you would use “%pyproject_buildrequires -r” to get the install_requires as BR’s, and ”%pytest” in %check, adding a manual BR on python3dist(pytest).

By the way, if you need to use a GitHub tarball, the %forgemeta macro is really helpful, *especially* if releases are not properly tagged. See for examples.

Comment 2 Ben Beasley 2021-05-31 13:30:41 UTC
Are you still working on this?

Comment 3 Package Review 2021-07-01 00:45:34 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per
we consider this ticket as DEADREVIEW and proceed to close it.

Note You need to log in before you can comment on or make changes to this bug.