Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 191389 - Review Request: oooqs2
Summary: Review Request: oooqs2
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michael J Knox
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-05-11 15:28 UTC by Dennis Gilmore
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-09-22 02:40:39 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
desktop russian translation patch (795 bytes, patch)
2006-06-02 10:27 UTC, Andy Shevchenko 		no flags Details | Diff
View All

Description Dennis Gilmore 2006-05-11 15:28:05 UTC 
Spec URL: http://www.ausil.us/packages/oooqs2.spec
SRPM URL: http://www.ausil.us/packages/oooqs2-1.0-1.fc5.src.rpm
Description: 
OpenOffice.org Quickstarter 2 is a small systray applet for KDE.
It is designed to preload OOo in memory  for faster startup
Comment 1 Andy Shevchenko 2006-06-02 10:27:21 UTC 
Created attachment 130394 [details]
desktop russian translation patch
Comment 2 Andy Shevchenko 2006-06-02 10:30:34 UTC 
I've translate desktop entry to Russian. 
Please, include attached patch in the package.

P.S. It's not review, just addon.
Comment 3 Andy Shevchenko 2006-06-03 11:02:25 UTC 
And just a note: why do you requires openoffice.org-* instead of only -core?
If I don't want to install the -writer (for example) and I should like to use 
oooqs2 with installed -calc only the oooqs2 installed me all monster office. 
It's no good solution as I think.
Comment 4 Dennis Gilmore 2006-06-03 14:45:54 UTC 
The reason i require  all the components  of openoffice.org  was because  the 
applet provides shortcuts for each of the different components  and if someone  
wanted to start oowriter from the applet and it did not work  they would  be 
surprised
Comment 5 Michael J Knox 2006-07-21 09:06:13 UTC 
Hey.. I will review this package.. 

----------------------------------------

Review for release 1:
* RPM name is OK
* Source oooqs2-1.0.tar.gz is the same as upstream
* Builds fine in mock
* File list looks OK

Needs work:
* BuildRequires: desktop-file-utils is missing
* rpmlint: need to fix symlink warnings
* The package should contain the text of the license
  (wiki: Packaging/ReviewGuidelines)
* Scriptlets: missing "gtk-update-icon-cache" in %post (wiki: ScriptletSnippets)
* Scriptlets: missing "gtk-update-icon-cache" in %postun (wiki: ScriptletSnippets)


Notes:

You fix up the %post/%postun scriplets, the is a COPYING file and it should be
included in the %docs

rpmlint of oooqs2:
W: oooqs2 dangling-symlink /usr/share/doc/HTML/de/oooqs2/common
/usr/share/doc/HTML/de/common
W: oooqs2 symlink-should-be-relative /usr/share/doc/HTML/de/oooqs2/common
/usr/share/doc/HTML/de/common
W: oooqs2 dangling-symlink /usr/share/doc/HTML/en/oooqs2/common
/usr/share/doc/HTML/en/common
W: oooqs2 symlink-should-be-relative /usr/share/doc/HTML/en/oooqs2/common
/usr/share/doc/HTML/en/common
Comment 6 Michael J Knox 2006-07-22 19:51:04 UTC 
As commented in the kmobiletools review, you will not need to add the gtk cruff
to your spec.
Comment 7 Dennis Gilmore 2006-07-27 20:06:17 UTC 
SPEC URL: http://ausil.us/packages/oooqs2.spec
SRPM URL: http://ausil.us/packages/oooqs2-1.0-2.fc5.src.rpm

added the COPYING File added the patch for Russian desktop file translation 

the dangling symlinks  cant fix   the files they point to are provided by 
kdelibs and the language packs this is extremely common in kde packages.  

the relative symlinks are fixed
Comment 8 Michael J Knox 2006-07-30 09:42:47 UTC 
Looks good. APPROVED. Please remember to close this review request once
inmported into CVS and built.
Comment 9 Kevin Fenzi 2006-09-02 20:49:35 UTC 
This package was imported, but doesn't seem to have been built yet. 
Is there a issue with the build?
Comment 10 Dennis Gilmore 2006-09-03 01:39:34 UTC 
ppc build failed  and i havent had a chance to work out why yet.
Comment 11 Dennis Gilmore 2006-09-22 02:40:39 UTC 
ok  built on all arches now :)
Note You need to log in before you can comment on or make changes to this bug.