Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 191434 - Review Request: xarchon - Arcade board game
Summary: Review Request: xarchon - Arcade board game
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Wart
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-05-11 22:01 UTC by Hans de Goede
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-05-15 19:14:44 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Hans de Goede 2006-05-11 22:01:30 UTC 
Spec URL: http://home.zonnet.nl/jwrdegoede/xarchon.spec
SRPM URL: http://home.zonnet.nl/jwrdegoede/xarchon-0.50-1.src.rpm
Description:
XArchon is a chess with a twist board game. It is modelled after the golden
oldie Archon game created by Freefall Associates.
Comment 1 Wart 2006-05-12 18:27:37 UTC 
MUST
====
 * rpmlint output clean
 * Sources match upstream
   491dea5b4e61ed13cd988d1c184a8ef0  xarchon-0.50.tar.gz
 * GPL license ok, license file included
 * Package and spec file named appropriately
 * .desktop file installed correctly
 * RPM_BUILD_ROOT cleaned appropriately
 * spec file is legible and in Am. English
 * No locales  * No shared libs
 * No -devel subpackage needed
 * No -docs subpackage needed
 * Not relocatable
 * Owns all directories that it creates
 * Builds fine in mock on FC-4-i386

MUSTFIX
=======
 * Macro use isn't consistent.  'xarchon' is used in some places, while
   %{name} is used in others.

SHOULD
======
 * Don't bother including the NEWS file, it just tells the user to read
the ChangeLog file.

 * Missing BR: libXpm-devel on FC-5.
Comment 2 Hans de Goede 2006-05-13 08:34:17 UTC 
(In reply to comment #1)
> MUSTFIX
> =======
>  * Macro use isn't consistent.  'xarchon' is used in some places, while
>    %{name} is used in others.
>
Fixed

> SHOULD
> ======
>  * Don't bother including the NEWS file, it just tells the user to read
> the ChangeLog file.
>
Done

>  * Missing BR: libXpm-devel on FC-5.
>
Added (for -devel too)

New version:
Spec URL: http://home.zonnet.nl/jwrdegoede/xarchon.spec
SRPM URL: http://home.zonnet.nl/jwrdegoede/xarchon-0.50-2.src.rpm
Comment 3 Ville Skyttä 2006-05-13 09:50:45 UTC 
Nit: hardcoded .gz man page suffix
Comment 4 Hans de Goede 2006-05-13 10:57:47 UTC 
I always use a harcoded .gz for the manpage suffix. I try to use as little
wildcards as possible in my %files sections. If a newer upstream versions
installs new files I want to know. I've seen people do %{_bindir}/*
%{_mandir}/man6/* etc, which IMHO is not a good idea.

I know that the compressing sometimes is done by rpmbuild and the manpage's are
installed uncompressed by make install, but AFAIK now a days they always end up
being compressed.
Comment 5 Wart 2006-05-15 17:53:50 UTC 
All MUST and SHOULD items addressed.  Runs without crashing (though I didn't
test it extensively).

APPROVED
Comment 6 Hans de Goede 2006-05-15 19:14:44 UTC 
Thanks! I would like todo something back but Chris has taken all your reviews
sofar :) Imported and Build.
Comment 7 Wart 2006-05-15 19:17:44 UTC 
#187392?  :)
Note You need to log in before you can comment on or make changes to this bug.