Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 191553 - Review Request: crossfire-maps - map files for the crossfire game server
Summary: Review Request: crossfire-maps - map files for the crossfire game server
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Christopher Stone
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-05-12 20:45 UTC by Wart
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-05-17 05:19:27 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Wart 2006-05-12 20:45:35 UTC 
Spec URL: http://www.kobold.org/~wart/fedora/crossfire-maps.spec
SRPM URL: http://www.kobold.org/~wart/fedora/crossfire-maps-1.9.0-1.src.rpm
Description: 
Maps for use with the crossfire game server
Comment 1 Christopher Stone 2006-05-16 00:10:57 UTC 
* rpmlint output
W: crossfire-maps no-documentation
W: crossfire-maps hidden-file-or-dir /usr/share/crossfire/maps/.emergency
W: crossfire-maps-devel no-documentation

- No documention warnings okay.
- .emergency file is okay I guess, rpmlint says to check if it's normal and
delete it if it's not.  The .emergency file looks like it's part of the world/
map stuff, but I cannot determine if it's needed.  I'm giving the benefit of the
doubt and saying it's needed.

* Package meets Package Naming Guidelines
* spec file match base package %{name}
* Package meets Package Guidelines
* Package licensed with open source license
* License matches crossfire license
* No license file in source package
* Spec file in American English
* Spec file legible
* Souces match upstream
265c4dfdbdedaa2c565ea831f5f74a0c  crossfire-1.9.0-1.maps.tar.gz
265c4dfdbdedaa2c565ea831f5f74a0c  crossfire-1.9.0-1.maps.tar.gz
* Package builds under mock for FC5 x86_64
* No BuildRequires needed
* Package does not use locales
* Package does not contain any shared libraries
* Package is not relocatable
* Package owns the directories it creates
* No duplicate files in %files
* All files have appropriate %defattr settings
* %clean section present
* Macro usage consistant
* Package contains permissible content
* Package does not contain large documentation to warrent a -doc package
* No files in %doc affect runtime
* Package does not contain headers or static libraries, or .pc files
* Package does not contain any .so files
* devel package contains fully versioned dependency on base package
* Package does not contain any .la files
* Package does not need a .desktop file
* Package does not own files or directories owned by other packages

*** APPROVED ***

Non-Blocking SHOULDs:
- SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
- SHOULD: Check hidden file .emergency to see if it is really required.
Comment 2 Wart 2006-05-16 00:23:48 UTC 
(In reply to comment #1)

> Non-Blocking SHOULDs:
> - SHOULD: If the source package does not include license text(s) as a separate
> file from upstream, the packager SHOULD query upstream to include it.

I've notified upstream:

https://sourceforge.net/tracker/index.php?func=detail&aid=1489214&group_id=13833&atid=113833

> - SHOULD: Check hidden file .emergency to see if it is really required.

It's used by common/init.c as a fallback for various map-related problems.
Comment 3 Wart 2006-05-17 04:11:42 UTC 
Imported and built.  Thanks!
Note You need to log in before you can comment on or make changes to this bug.