Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 191619 - Review Request: perl-CSS-Tiny - Read/Write .css files with as little code as possible
Summary: Review Request: perl-CSS-Tiny - Read/Write .css files with as little code as ...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT 191620
TreeView+ depends on / blocked
 
Reported: 2006-05-13 23:10 UTC by Jose Pedro Oliveira
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-05-15 23:42:10 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Jose Pedro Oliveira 2006-05-13 23:10:10 UTC
Spec URL:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-CSS-Tiny.spec

SRPM URL:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-CSS-Tiny-1.11-1.src.rpm

Description:
CSS::Tiny is a perl class to read and write .css stylesheets with as
little code as possible, reducing load time and memory overhead.

Comment 1 Jason Tibbitts 2006-05-15 15:22:23 UTC
Everything looks good; the only thing I question is the reason for including
test.css as %doc.  It seems a bit pointless to me, but I guess it doesn't hurt
anything.

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* license field matches the actual license.
* license is open source-compatible.  License text is included in the package.
* source files match upstream:
   66fac70597a4e6628f1875037d1d2a94  CSS-Tiny-1.11.tar.gz
   66fac70597a4e6628f1875037d1d2a94  CSS-Tiny-1.11.tar.gz-srpm
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass:
   All tests successful.
   Files=4, Tests=47,  0 wallclock secs ( 0.14 cusr +  0.06 csys =  0.20 CPU)
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED

Comment 2 Jose Pedro Oliveira 2006-05-15 23:42:10 UTC
(In reply to comment #1)
> Everything looks good; the only thing I question is the reason for including
> test.css as %doc.  It seems a bit pointless to me, but I guess it doesn't hurt
> anything.

Indeed. I could swear it was a CSS example with more juicy. I will remove next
update.


Imported and built for FC-5 and devel.



Note You need to log in before you can comment on or make changes to this bug.