Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 191623 - Review Request: perl-Expect-Simple - Wrapper around the Expect module
Summary: Review Request: perl-Expect-Simple - Wrapper around the Expect module
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On: 191622
Blocks: FE-ACCEPT 191624
TreeView+ depends on / blocked
 
Reported: 2006-05-13 23:29 UTC by Jose Pedro Oliveira
Modified: 2010-06-23 01:34 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-05-17 16:55:04 UTC
Type: ---
Embargoed:
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Jose Pedro Oliveira 2006-05-13 23:29:43 UTC 
Spec URL: 
http://gsd.di.uminho.pt/jpo/software/fedora/perl-Expect-Simple.spec
SRPM URL:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-Expect-Simple-0.02-1.src.rpm

Description: 
Expect::Simple is a wrapper around the Expect module which should
suffice for simple applications. It hides most of the Expect
machinery; the Expect object is available for tweaking if need be.
Comment 1 Jason Tibbitts 2006-05-16 22:58:03 UTC 
There's not much to this one.

* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* license field matches the actual license.
* license is open source-compatible; license text is included in the package.
* source files match upstream:
   23c72fa4461f07522eb8c8511bad5d43  Expect-Simple-0.02.tar.gz
   23c72fa4461f07522eb8c8511bad5d43  Expect-Simple-0.02.tar.gz-srpm
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64) with perl-Expect added.
* rpmlint is silent.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and the single test passes:
   1..1
   ok 1
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED
Comment 2 Jose Pedro Oliveira 2006-05-17 16:55:04 UTC 
Thanks for the review.

Imported and built for FC-5 and devel.
Comment 3 Mark Chappell 2010-06-21 08:09:07 UTC 
https://bugzilla.redhat.com/show_bug.cgi?id=191622 - cweyl implied he's not
interested in EPEL, and at the last EPEL meeting Smooge suggested I should just
put the requests through.

Package Change Request
======================
Package Name: perl-Expect-Simple
New Branches: EL-5 EL-6
Owners: tremble
Comment 4 Kevin Fenzi 2010-06-23 01:34:31 UTC 
cvs done.
Note You need to log in before you can comment on or make changes to this bug.