Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 192144 - Review Request: musicbox
Summary: Review Request: musicbox
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Brian Pepple
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-05-17 21:06 UTC by Damien Durand
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-05-28 14:06:43 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Damien Durand 2006-05-17 21:06:20 UTC 
Spec URL: http://glive.tuxfamily.org/fedora/musicbox/musicbox.spec
SRPM URL: http://glive.tuxfamily.org/fedora/musicbox/musicbox-0.2.3-1.src.rpm
Description: Musicbox is a simple one-file-at-a-time audio tag editor. It can edit 
ID3, Vorbis and FLAC tags via the TagLib library.
Comment 1 Brian Pepple 2006-05-18 15:06:55 UTC 
Package fails to build in Mock.  Your missing a build requirement.
Comment 2 Damien Durand 2006-05-20 13:36:51 UTC 
New spec file and srpm are here: http://glive.tuxfamily.org/fedora/musicbox/
Comment 3 Brian Pepple 2006-05-20 17:32:44 UTC 
MD5Sums:
03f9eb2c446debd1e187d472c05dcad8  musicbox-0.2.3.tar.gz

Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guide
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* Desktop entry is fine
* All directories are owned by this or other packages
* All necessary BuildRequires listed.
* All desired features are enabled
* rpmlint produces no errors.
* Builds fine in mock.

Minor:
* Unnecessary BuildRequirement: gtk2-devel (provided by libglade2-devel)
* Don't package INSTALL doc, since it's the generic GNU file.

You can fix the 2 minor issues when you import it into FE CVS.

+1 APPROVE
Comment 4 Brian Pepple 2006-05-28 13:52:44 UTC 
Damien, has then been build for FC5 & devel?  If so, this can be closed.
Note You need to log in before you can comment on or make changes to this bug.