Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1923373 - aespipe: FTBFS in Fedora rawhide/f34
Summary: aespipe: FTBFS in Fedora rawhide/f34
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: aespipe
Version: 34
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Orphan Owner
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F34FTBFS
TreeView+ depends on / blocked
 
Reported: 2021-02-01 16:39 UTC by Fedora Release Engineering
Modified: 2023-11-13 01:04 UTC (History)
3 users (show)

Fixed In Version: aespipe-2.4g-1.fc38 aespipe-2.4g-1.el9 aespipe-2.4g-1.fc37 aespipe-2.4g-1.fc39
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-06-07 20:57:25 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
build.log (deleted)
2021-02-01 16:39 UTC, Fedora Release Engineering
no flags Details
root.log (deleted)
2021-02-01 16:39 UTC, Fedora Release Engineering
no flags Details
state.log (deleted)
2021-02-01 16:39 UTC, Fedora Release Engineering
no flags Details

Description Fedora Release Engineering 2021-02-01 16:39:50 UTC
aespipe failed to build from source in Fedora rawhide/f34

https://koji.fedoraproject.org/koji/taskinfo?taskID=60908590


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild
Please fix aespipe at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
aespipe will be orphaned. Before branching of Fedora 35,
aespipe will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/

Comment 1 Fedora Release Engineering 2021-02-01 16:39:52 UTC
Created attachment 1753157 [details]
build.log

Comment 2 Fedora Release Engineering 2021-02-01 16:39:53 UTC
Created attachment 1753158 [details]
root.log

file root.log too big, will only attach last 32768 bytes

Comment 3 Fedora Release Engineering 2021-02-01 16:39:54 UTC
Created attachment 1753159 [details]
state.log

Comment 4 Ben Cotton 2021-02-09 15:49:20 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 34 development cycle.
Changing version to 34.

Comment 5 Fedora Release Engineering 2021-02-14 04:24:13 UTC
Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 34.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2021-03-29).

A week before the mass branching of Fedora 35 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 33 will be
retired regardless of the status of this bug.

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-35/f-35-key-tasks.html

Comment 6 Fedora Release Engineering 2021-03-07 04:23:11 UTC
Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 34.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2021-03-29).

A week before the mass branching of Fedora 35 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 33 will be
retired regardless of the status of this bug.

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-35/f-35-key-tasks.html

Comment 7 Fedora Release Engineering 2021-03-28 04:22:30 UTC
Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 34.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2021-03-29).

A week before the mass branching of Fedora 35 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 33 will be
retired regardless of the status of this bug.

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-35/f-35-key-tasks.html

Comment 8 Fedora Release Engineering 2021-04-18 04:22:27 UTC
Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 34.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2021-03-29).

A week before the mass branching of Fedora 35 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 33 will be
retired regardless of the status of this bug.

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-35/f-35-key-tasks.html

Comment 9 Fedora Release Engineering 2021-05-09 04:22:25 UTC
Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 34.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2021-03-29).

A week before the mass branching of Fedora 35 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 33 will be
retired regardless of the status of this bug.

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-35/f-35-key-tasks.html

Comment 10 Fedora Release Engineering 2021-05-30 04:22:17 UTC
Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 34.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2021-03-29).

A week before the mass branching of Fedora 35 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 33 will be
retired regardless of the status of this bug.

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-35/f-35-key-tasks.html

Comment 11 Fedora Release Engineering 2021-06-20 04:22:18 UTC
Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 34.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2021-03-29).

A week before the mass branching of Fedora 35 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 33 will be
retired regardless of the status of this bug.

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-35/f-35-key-tasks.html

Comment 12 Ben Cotton 2022-05-12 15:08:32 UTC
This message is a reminder that Fedora Linux 34 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 34 on 2022-06-07.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '34'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 34 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 13 Ben Cotton 2022-06-07 20:57:25 UTC
Fedora Linux 34 entered end-of-life (EOL) status on 2022-06-07.

Fedora Linux 34 is no longer maintained, which means that it
will not receive any further security or bug fix updates. As a result we
are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 14 Red Hat Bugzilla 2023-09-15 01:32:14 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 365 days

Comment 15 Jiri Hladky 2023-10-17 23:47:50 UTC
The build process got broken because of GCC bug. 

when compiling aespipe from sources (https://loop-aes.sourceforge.net/aespipe/), GCC produces a wrong binary that generates the wrong cipher text when encrypting known text. This happens with these two compilation flags used TOGETHER:

CFLAGS="-O2 -flto=auto"
Interstingly, i686 and x86_64 arches are NOT AFFECTED. Only these arches are known to be affected:

armv7hl
aarch64
ppc64le
s390x
The problem was first spotted when compiling aespipe package for Fedora-34:
https://koji.fedoraproject.org/koji/taskinfo?taskID=62266480

On Fedora-33, the package has compiled without problems.

gcc v10 is known as the last working version
gcc v11 is known as the first broken version

The issue persists when compiling aespipe for Fedora rawhide with GCC v13.

WORKAROUND is to use
CFLAGS="-O1 -flto=auto"
or
CFLAGS="-O0 -flto=auto"

or omit -flto=auto:
CFLAGS="-O2"


Reproducer:

wget https://loop-aes.sourceforge.net/aespipe/aespipe-v2.4f.tar.bz2
tar xvf aespipe-v2.4f.tar.bz2
cd aespipe-v2.4f
make clean; ./configure CFLAGS="-O2 -flto=auto"; make; make tests
When binary is correct (expected output):

*** Test results ok ***
aespipe was compiled correctly and has generated the desired output when encrypting and decrypting messages.

When the binary is wrong (reproducing the issue):

make[1]: Entering directory '/root/A/aespipe-v2.4f'
./aespipe -v -p 3 -e AES128 -K ./gpgkey2.asc -G test-dir1 <test-file3 >test-file1 3<test-file4
./aespipe: C-language AES, 128 key bits, encrypting, multi-key-v2 mode, RAM not locked
make test-part3
make[2]: Entering directory '/root/A/aespipe-v2.4f'
md5sum test-file1 >test-file2
echo "f9825b79873f5c439ae9371c1a929a6c  test-file1" >test-file5
make[2]: Leaving directory '/root/A/aespipe-v2.4f'
cmp test-file2 test-file5
test-file2 test-file5 differ: byte 1, line 1
make[1]: *** [Makefile:120: test-part2] Error 1
make[1]: Leaving directory '/root/A/aespipe-v2.4f'
make: *** [Makefile:87: tests] Error 2
It means that aespipe has NOT generated the expected output. The message was encrypted wrongly.


WORKAROUND: - use -O0 optimization.
Here is the build section of the aespipe.spec file:

%build
%set_build_flags
# If you use multiple -O options, with or without level numbers, the last such option is the one that is effective.
# https://gcc.gnu.org/onlinedocs/gcc-11.2.0/gcc/Optimize-Options.html#Optimize-Options
# https://issues.redhat.com/browse/RHEL-14046
CFLAGS="$CFLAGS -O0"

# Package calls CC to link
%configure LDFLAGS="${CFLAGS}"

%global make_target %{nil}
%ifarch x86_64
%global make_target amd64
%endif
%ifarch %{ix86}
%global make_target x86
%endif
make %{?_smp_mflags} %{make_target}


See also:
Bug 2244729 - Review Request: aespipe - AES encrypting or decrypting pipe
https://bugzilla.redhat.com/show_bug.cgi?id=2244729

Comment 16 Florian Weimer 2023-10-18 09:02:18 UTC
(In reply to Jiri Hladky from comment #15)
> The build process got broken because of GCC bug.

Do you have a link to the upstream GCC bug report?

In many cases, behavioral changes after compiler upgrades are results of package bugs (incorrect use of the C language).

Comment 17 Jiri Hladky 2023-10-18 15:09:07 UTC
Hi Florian,

thanks for looking into it! 

Here is the Jira issue:
https://issues.redhat.com/browse/RHEL-14046
gcc with CFLAGS="-O2 -flto=auto" produces a binary with changed function


I'm adding summary what we have discussed in the chat:

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Florian Weimer has suggested following:

=================================================================================================
Try building with -fno-strict-aliasing or -fno-ipa-modref or both. If that fixes it, it's likely a source code issue.

The code for DATA_ALWAYS_ALIGNED does not look correct. It would be better to undefine it and rely on GCC generating unaligned accesses. It recognizes the byte-wise access construct.
=================================================================================================

I have confirmed that building both with
CFLAGS="-O2 -flto=auto -fno-strict-aliasing"
and
CFLAGS="-O2 -flto=auto -fno-ipa-modref"

fixes the issue.

I have contacted the author of aespipe to review the DATA_ALWAYS_ALIGNED in aes.c source file.

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++


Thanks a lot
Jirka

Comment 18 Fedora Update System 2023-11-03 01:16:13 UTC
FEDORA-EPEL-2023-725614ab0d has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-725614ab0d

Comment 19 Fedora Update System 2023-11-03 01:31:02 UTC
FEDORA-2023-06d5b0e15e has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-06d5b0e15e

Comment 20 Fedora Update System 2023-11-03 01:31:35 UTC
FEDORA-2023-951d88f408 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-951d88f408

Comment 21 Fedora Update System 2023-11-03 01:32:08 UTC
FEDORA-2023-3f568e2a3f has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-3f568e2a3f

Comment 22 Fedora Update System 2023-11-04 03:45:17 UTC
FEDORA-2023-951d88f408 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-951d88f408`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-951d88f408

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 23 Fedora Update System 2023-11-04 03:56:02 UTC
FEDORA-EPEL-2023-725614ab0d has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-725614ab0d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 24 Fedora Update System 2023-11-04 05:09:34 UTC
FEDORA-2023-3f568e2a3f has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-3f568e2a3f`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-3f568e2a3f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 25 Fedora Update System 2023-11-05 21:37:32 UTC
FEDORA-2023-06d5b0e15e has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-06d5b0e15e`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-06d5b0e15e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 26 Fedora Update System 2023-11-12 01:42:30 UTC
FEDORA-2023-951d88f408 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 27 Fedora Update System 2023-11-12 01:56:04 UTC
FEDORA-EPEL-2023-725614ab0d has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 28 Fedora Update System 2023-11-12 02:37:12 UTC
FEDORA-2023-3f568e2a3f has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 29 Fedora Update System 2023-11-13 01:04:30 UTC
FEDORA-2023-06d5b0e15e has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.