Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1923779 - Review Request: catalyst - API specification for simulations to analyze and visualize data in situ
Summary: Review Request: catalyst - API specification for simulations to analyze and v...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1923074
TreeView+ depends on / blocked
 
Reported: 2021-02-01 21:45 UTC by Orion Poplawski
Modified: 2021-02-23 03:18 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-02-23 03:18:43 UTC
Type: Bug
Embargoed:
zbyszek: fedora-review+

Attachments (Terms of Use)

Description Orion Poplawski 2021-02-01 21:45:27 UTC 
Spec URL: https://www.cora.nwra.com/~orion/fedora/catalyst.spec
SRPM URL: https://www.cora.nwra.com/~orion/fedora/catalyst-2.0-0.1.20201218git2fc94c5.fc34.src.rpm

Description:
Catalyst is an API specification developed for simulations (and other
scientific data producers) to analyze and visualize data in situ.

Originally, Catalyst was part of ParaView. However, with ParaView version
5.9, the Catalyst API was revamped quite extensively and release as an
independent project. This repository includes the definition together with a
lightweight implementation of this revamped Catalyst API.

The documentation describing the details, including build instructions and
how to use Catalyst for in situ analysis and visualization in simulations is
available here: https://catalyst-in-situ.readthedocs.io/en/latest/index.html

Fedora Account System Username: orion

Scratch build - https://koji.fedoraproject.org/koji/taskinfo?taskID=61063693
Comment 1 Zbigniew Jędrzejewski-Szmek 2021-02-20 12:48:22 UTC 
> Originally, Catalyst was part of ParaView. However, with ParaView version
> 5.9, the Catalyst API was revamped quite extensively and release as an
> independent project. This repository includes the definition together with a
> lightweight implementation of this revamped Catalyst API.
>
> The documentation describing the details, including build instructions and
> how to use Catalyst for in situ analysis and visualization in simulations is
> available here: https://catalyst-in-situ.readthedocs.io/en/latest/index.html

"d" is missing. But alltogether, this is not very intesting for users. Maybe:

Catalyst has been split out of ParaView. This package includes the definition together with a
lightweight implementation of this Catalyst API.

For details how to use Catalyst for in situ analysis and visualization in simulations,
see https://catalyst-in-situ.readthedocs.io/en/latest/index.html.

+ pakcage name is OK
+ license is acceptable for Fedora (BSD 3-clause)
+ license is specified correctly
+ builds and installs OK
+ BR look correct
+ P:bundled() is used where appropriate
+ P/R look correct

rpmlint:
catalyst.src: W: spelling-error Summary(en_US) situ -> sit, suit, site
catalyst.src: W: spelling-error %description -l en_US situ -> sit, suit, site
catalyst.src: W: strange-permission catalyst-2fc94c55ba4eb994f27728141ebcf15c3435f306.tar.gz 660
catalyst.src: W: strange-permission catalyst-unbundle.patch 660
catalyst.src: W: strange-permission catalyst.spec 660
catalyst.src:24: W: unversioned-explicit-provides bundled(conduit)
catalyst.x86_64: W: spelling-error Summary(en_US) situ -> sit, suit, site
catalyst.x86_64: W: spelling-error %description -l en_US situ -> sit, suit, site
catalyst.x86_64: W: no-documentation
catalyst-devel.x86_64: W: no-documentation
5 packages and 0 specfiles checked; 0 errors, 10 warnings.
Nothing important here.

Package is APPROVED.
Comment 2 Zbigniew Jędrzejewski-Szmek 2021-02-20 12:55:44 UTC 
Oh, please add
%license License.txt 3rdPartyLicenses.txt
Comment 3 Orion Poplawski 2021-02-21 03:57:18 UTC 
Thanks for the review, will make the changes.
Comment 4 Mohan Boddu 2021-02-22 23:00:29 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/catalyst
Comment 5 Orion Poplawski 2021-02-23 03:18:43 UTC 
Checked in and built.
Note You need to log in before you can comment on or make changes to this bug.