Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 192603 - Review Request: openalpp - Object Oriented version of OpenAL
Summary: Review Request: openalpp - Object Oriented version of OpenAL
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Hans de Goede
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-05-21 20:06 UTC by Christopher Stone
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-06-01 22:40:11 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Christopher Stone 2006-05-21 20:06:08 UTC
Spec URL: http://tkmame.retrogames.com/fedora-extras/openalpp.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/openalpp-20060405-2.src.rpm

Description:
Written in C++, makes OpenAL so much more accessible. Compare openalpp to a
scenegraph for OpenGL.

Comment 1 Hans de Goede 2006-05-29 06:01:49 UTC
Claiming this one before Mike (wart) does it, so that I actually get a chance to
give some reviews back for all the reviews you have been doing for me :)

Dunno when I have the time todo the actual review though, might take a couple of
days (but no longer).


Comment 2 Hans de Goede 2006-05-29 08:55:47 UTC
MUST:
=====
* rpmlint output is: 
 W: openalpp-devel no-documentation
 No problem here.
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License (LGPL) ok, license file included
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on devel-i386
* BR: ok
* No locales
* ldconfig properly called for shared libraries
* Not relocatable
* Package owns / or requires all dirs
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code only
* %doc does not affect runtime, and isn't large enough to warrent a sub package
* proper -devel package needed
* .la files not packaged
* no gui -> no .desktop file required


MUST fix:
=========
* Group: for the base package is wrong it should be:
 "System Environment/Libraries"


Should fix:
===========
* Why patch 3330 ???


Comment 3 Christopher Stone 2006-05-30 19:48:03 UTC
Spec URL: http://tkmame.retrogames.com/fedora-extras/openalpp.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/openalpp-20060405-3.src.rpm

%changelog
* Tue May 30 2006 Christopher Stone <chris.stone> 20060405-3
- Fix Group
- Fix patch number

The debian guys added that patch to the spec file, I'm not sure why they chose
3330, I've changed it back to just patch0.  Group has also been fixed.  Thanks
for the review!

I'm not sure if you noticed, but I did approve the xgalaga package a week ago.

Comment 4 Hans de Goede 2006-05-31 07:08:08 UTC
All problems fixed -> approved!

> I'm not sure if you noticed, but I did approve the xgalaga package a week ago.

No I didn't notice, this must have fallen through the cracks, thanks for the
headsup.


Note You need to log in before you can comment on or make changes to this bug.