Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1928481 - Regression from patch for #623667 on 64-bit systems
Summary: Regression from patch for #623667 on 64-bit systems
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: seeker
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-02-14 11:41 UTC by aurhb20
Modified: 2021-02-24 20:46 UTC (History)
2 users (show)

Fixed In Version: seeker-3.0-24.fc33 seeker-3.0-24.fc32
Doc Type: ---
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-02-24 20:41:36 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Revised seeker-3.0-timeout-blockalign-623667.patch (2.48 KB, patch)
2021-02-14 12:54 UTC, aurhb20
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 623667 0 low CLOSED seeker hits random bytes unaligened 2022-05-16 11:32:56 UTC

Description aurhb20 2021-02-14 11:41:17 UTC
Description of problem:
The #623667 patch uses memalign() without corresponding #include, causing the compiler to implicitly truncate the return value to 32-bit int.

Version-Release number of selected component (if applicable):
3.0-21

How reproducible:
Always

Steps to Reproduce:
1. Run seeker <any blockdev> on an x86-64 machine.

Actual results:
seeker fails with read: Bad address

Expected results:
seeker works successfully.

Additional info:
The patch also removes support for (ancient) libc w/o BLKGETSIZE64, which was broken anyway--BLKGETSIZE returns size in units of sectors (512), not bytes (1).

Comment 1 aurhb20 2021-02-14 12:54:30 UTC
Created attachment 1756931 [details]
Revised seeker-3.0-timeout-blockalign-623667.patch

Comment 2 Fedora Update System 2021-02-16 17:36:42 UTC
FEDORA-2021-30a4cdd7f2 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-30a4cdd7f2

Comment 3 Fedora Update System 2021-02-17 05:59:41 UTC
FEDORA-2021-30a4cdd7f2 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-30a4cdd7f2`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-30a4cdd7f2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 4 Fedora Update System 2021-02-17 06:03:03 UTC
FEDORA-2021-5b55423fb5 has been pushed to the Fedora 32 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-5b55423fb5`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-5b55423fb5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 5 Fedora Update System 2021-02-24 20:41:36 UTC
FEDORA-2021-30a4cdd7f2 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fedora Update System 2021-02-24 20:46:12 UTC
FEDORA-2021-5b55423fb5 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.