Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 193470 - Review Request: renrot - A program to rename and rotate files according to EXIF tags
Summary: Review Request: renrot - A program to rename and rotate files according to EX...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
Depends On:
TreeView+ depends on / blocked
Reported: 2006-05-29 11:29 UTC by Andy Shevchenko
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2006-06-03 15:46:16 UTC
Type: ---

Attachments (Terms of Use)

Description Andy Shevchenko 2006-05-29 11:29:21 UTC
Spec URL:
Renrot renames files according the DateTimeOriginal and FileModifyDate
EXIF tags, if they exist. Otherwise, the name will be set according to
the current timestamp. Additionally, it rotates files and their
thumbnails, accordingly Orientation EXIF tag.

The script can also put commentary into the Commentary and UserComment

Personal details can be specified via XMP tags defined in a
configuration file.

Comment 1 Parag AN(पराग) 2006-06-01 06:50:29 UTC
It will be good it you specify what changes you made from version to version
release in SPEC file'c Chnagelog

Comment 2 Andy Shevchenko 2006-06-01 11:35:58 UTC
Why? The spec's changelog is related to spec changes and so on.
I think, if you should like to get changes list of project you should read the 
project's inside documentation such ChangeLog or NEWS files, isn't it?
(Look to wine package for example)

Updated version here:

Comment 3 Jason Tibbitts 2006-06-03 01:37:29 UTC
rpmlint complains:

E: renrot non-standard-executable-perm /usr/bin/renrot 0555

Should be 755.

The only other issue is minor; BuildRequires: perl is not required.  This is not
a blocker.

Since the only real issue is fixed up by a quick chmod, I'll go ahead and
approve this and you can fix it when you check in.

* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* source files match upstream:
   b3261caa8ed7a6c87add693310feb9b9  renrot-0.20.tar.gz
   b3261caa8ed7a6c87add693310feb9b9  renrot-0.20.tar.gz-srpm
* latest version is being packaged.
O BuildRequires are proper (BR: perl is redundant)
* package builds in mock (development, x86_64).
X rpmlint complains about mode 555 file.
* final provides and requires are sane:
   config(renrot) = 0.20-1.fc6
   renrot = 0.20-1.fc6
   config(renrot) = 0.20-1.fc6
   libjpeg >= 6b
   perl >= 0:5.006
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
X file permissions are appropriate.
* %clean is present.
* %check is not present; no test suite upstream.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED, provided you fix the permissions on /usr/bin/renrot.

Comment 4 Andy Shevchenko 2006-06-03 10:40:59 UTC
Updated version here:

Comment 5 Jason Tibbitts 2006-06-03 15:07:40 UTC
Everything looks good; check in whenever you like.

Comment 6 Andy Shevchenko 2006-06-03 15:46:16 UTC
Thank you for review.

Note You need to log in before you can comment on or make changes to this bug.