Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1935610 - Review Request: fdesc - CLI tools to generate fake description
Summary: Review Request: fdesc - CLI tools to generate fake description
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR
TreeView+ depends on / blocked
 
Reported: 2021-03-05 09:34 UTC by masoud bolhassani
Modified: 2021-03-21 18:56 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description masoud bolhassani 2021-03-05 09:34:08 UTC 
This is my first package and I am seeking a sponsor.

* Spec URL: https://raw.githubusercontent.com/msoodb/fdesc/master/fdesc.spec
* SRPM URL: https://raw.githubusercontent.com/msoodb/fdesc/master/SRPM/fdesc-0-1.fc32.src.rpm
* Description: CLI tools to generate fake description (https://github.com/msoodb/fdesc).
* Fedora Account System Username: msoodb

This package is also hosted in COPR with successful build on F32, F33, F34, Rawhide.

* https://copr.fedorainfracloud.org/coprs/msoodb/fdesc
* https://koji.fedoraproject.org/koji/taskinfo?taskID=63274895
Comment 1 Robert-André Mauchin 🐧 2021-03-16 09:56:41 UTC 
 - You can use %set_build_flags instead of:

export CFLAGS="%{optflags}"
export LDFLAGS="%{__global_ldflags}"

 - You can't use master for the archive as it will change with new commit. You should instead define the commit you want packaged:

%global commit          57bc98c139d13f1f79404c72445193e8fcdfcc60
%global snapshotdate    20210316
%global shortcommit     %(c=%{commit}; echo ${c:0:7})

[…]

Release:        0.1%{snapshotdate}git%{shortcommit}%{?dist}

[…]

Source0:        %url/archive/%{commit}/%{name}-%{shortcommit}.tar.gz

[…]

%autosetup -n %{name}-%{commit}

[…]

* Wed Mar  3 2021 msoodb <masoud.bolhassani> - 0-0.1.20210316git57bc98c

 - Release should start at 0.1 for a prerelease

 - Remove trailing spaces
Comment 2 masoud bolhassani 2021-03-21 11:51:18 UTC 
>> You can use %set_build_flags instead of: 
DONE.


>> You can't use master for the archive as it will change with new commit. You should instead define the commit you want packaged:
I don't get the point. I should dread more about packaging. The document I followed doesn't mention it.
Comment 3 Robert-André Mauchin 🐧 2021-03-21 18:46:31 UTC 
(In reply to masoud bolhassani from comment #2)
> 
> >> You can't use master for the archive as it will change with new commit. You should instead define the commit you want packaged:
> I don't get the point. I should dread more about packaging. The document I
> followed doesn't mention it.

The Master tip of the Github repo is not stable, every new commit will change it and with it the archive you point to, you need to package a specific commit that won't change.
Comment 4 Robert-André Mauchin 🐧 2021-03-21 18:56:15 UTC 
(In reply to Robert-André Mauchin 🐧 from comment #3)
> (In reply to masoud bolhassani from comment #2)
> > 
> > >> You can't use master for the archive as it will change with new commit. You should instead define the commit you want packaged:
> > I don't get the point. I should dread more about packaging. The document I
> > followed doesn't mention it.
> 
> The Master tip of the Github repo is not stable, every new commit will
> change it and with it the archive you point to, you need to package a
> specific commit that won't change.

Disregard, I've noticed that you point to an archive in your Git repo. You should probably not do that and instead use Git to tag new releases instead of uploading archive. You shouldn't upload the SRPM here either, binary content do not play well with GIT.
Note You need to log in before you can comment on or make changes to this bug.