Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1937041 (kirigami-gallery) - Review Request: kirigami-gallery - Gallery application built using Kirigami
Summary: Review Request: kirigami-gallery - Gallery application built using Kirigami
Keywords:
Status: ASSIGNED
Alias: kirigami-gallery
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2021-03-09 17:38 UTC by Onuralp SEZER
Modified: 2021-03-25 13:50 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Onuralp SEZER 2021-03-09 17:38:31 UTC
Spec URL: https://pagure.io/kirigami_gallery_rpm/blob/main/f/kirigami-gallery.spec
SRPM URL: https://pagure.io/kirigami_gallery_rpm/blob/main/f/kirigami-gallery-20.12.3-1.fc34.src.rpm

Description: Example application which uses all features from kirigami, including links to the sourcecode, tips on how to use the components and links to the corresponding HIG pages and code examples on invent.


Fedora Account System Username: thunderbirdtr

Copr build : https://copr.fedorainfracloud.org/coprs/thunderbirdtr/kirigami-gallery/package/kirigami-gallery/

Comment 1 Robert-André Mauchin 🐧 2021-03-16 15:18:12 UTC
 - Could you point to a more specific page rather than kde.org?

URL:    https://www.kde.org

For example https://apps.kde.org/en/kirigami2.gallery

 - The license shorhand for LGPL v2 is:

License: LGPLv2+

 - Remove trailing spaces

 - The appstream validation must be performed without network access:

appstreamcli validate --no-net %{buildroot}%{_metainfodir}/org.kde.kirigami2.gallery.appdata.xml

 - Please add an explicit BR for gcc-c++

 - You'll need to find a sponsor, see https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU Library General Public License,
     Version 2.0", "GNU Library General Public License v2 or later". 81
     files have unknown license. Detailed output of licensecheck in
     /home/bob/packaging/review/kirigami-gallery/review-kirigami-
     gallery/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: kirigami-gallery-20.12.3-1.fc35.x86_64.rpm
          kirigami-gallery-debuginfo-20.12.3-1.fc35.x86_64.rpm
          kirigami-gallery-debugsource-20.12.3-1.fc35.x86_64.rpm
          kirigami-gallery-20.12.3-1.fc35.src.rpm
kirigami-gallery.x86_64: W: invalid-license LGPL-2.0
kirigami-gallery.x86_64: W: no-manual-page-for-binary kirigami2gallery
kirigami-gallery-debuginfo.x86_64: W: invalid-license LGPL-2.0
kirigami-gallery-debugsource.x86_64: W: invalid-license LGPL-2.0
kirigami-gallery.src: W: invalid-license LGPL-2.0
4 packages and 0 specfiles checked; 0 errors, 5 warnings.

Comment 2 Onuralp SEZER 2021-03-16 20:05:38 UTC
Thank you for review

URL updated to -> https://apps.kde.org/en/kirigami2.gallery

License changed to : LGPLv2+

 - Remove trailing spaces (done)

 - The appstream validation must be performed without network access: (done)

      -  appstreamcli validate --no-net %{buildroot}%{_metainfodir}/org.kde.kirigami2.gallery.appdata.xml 

 - Please add an explicit BR for gcc-c++  (added)


After these changes, I made new copr built and sent commit to pagure repo so, all the link are same.

Comment 3 Robert-André Mauchin 🐧 2021-03-17 07:10:03 UTC
Package approved, you still need to find a sponsor.

Comment 4 Rex Dieter 2021-03-17 13:46:47 UTC
I just sponsored thunderbirdtr into packager group, use your powers for good.

Comment 5 Onuralp SEZER 2021-03-24 13:05:55 UTC
Thank you Rex, for sponsoring me.

And "friendly ping" any updates to push the src.fpo ? :)

Comment 6 Rex Dieter 2021-03-24 17:25:38 UTC
Not sure what you're asking, but I'm guessing next steps that involve action on your part, starting at ... 

https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner

Comment 7 Onuralp SEZER 2021-03-24 22:33:08 UTC
Thank you, I missed that part, and ticket opened.

Comment 8 Gwyn Ciesla 2021-03-25 13:50:07 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/kirigami-gallery


Note You need to log in before you can comment on or make changes to this bug.