Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1945938 - Review Request: rgbds - An assembly toolchain for the Nintendo Game Boy & Game Boy Color
Summary: Review Request: rgbds - An assembly toolchain for the Nintendo Game Boy & Gam...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR 1944764
TreeView+ depends on / blocked
 
Reported: 2021-04-02 19:03 UTC by Jan Drögehoff
Modified: 2021-04-03 16:04 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-04-03 16:04:32 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Jan Drögehoff 2021-04-02 19:03:17 UTC
Spec URL: https://pagure.io/rgbds-rpm/raw/0adf657ecd48d77c72b302f8547bab78e3e6ee44/f/rgbds.spec
SRPM URL: https://releases.pagure.org/rgbds-rpm/rgbds-0.4.2-1.fc33.src.rpm

Description:
RGBDS (Rednex Game Boy Development System) is a free assembler/linker package
for the Game Boy and Game Boy Color.

It consists of:

* rgbasm (assembler)
* rgblink (linker)
* rgbfix (checksum/header fixer)
* rgbgfx (PNG‐to‐2bpp graphics converter)

Fedora Account System Username: sentry
This is my first Fedora package so I'm looking for a sponsor

rpmlint output:
> rgbds.src: W: spelling-error Summary(en_US) toolchain -> tool chain, tool-chain, touchline
> rgbds.src: W: spelling-error %description -l en_US rgbasm -> orgasm
> rgbds.src: W: spelling-error %description -l en_US rgblink -> blink
> rgbds.src: W: spelling-error %description -l en_US rgbfix
> rgbds.src: W: spelling-error %description -l en_US checksum -> check sum, check-sum, checks um
> rgbds.src: W: spelling-error %description -l en_US rgbgfx

Comment 1 Robert-André Mauchin 🐧 2021-04-02 23:47:04 UTC
 - No review yet but please also set the default ldflags:

LDFLAGS=%{build_ldflags}

 - Please BR 'make' explicitly

BuildRequires:  make

Comment 2 Jan Drögehoff 2021-04-02 23:57:17 UTC
Totally forgot about that, thanks for pointing that out

Spec URL: https://pagure.io/rgbds-rpm/raw/fe057a23e365af103cfe9c82ff5c9e5f0483590f/f/rgbds.spec
SRPM URL: https://releases.pagure.org/rgbds-rpm/rgbds-0.4.2-1.fc33.src1.rpm

Comment 3 Robert-André Mauchin 🐧 2021-04-03 16:04:32 UTC
It seems already packaged: https://src.fedoraproject.org/rpms/rgbds


Note You need to log in before you can comment on or make changes to this bug.